Remove even more deprecated code#9640
Remove even more deprecated code#9640ingorichter merged 5 commits intoadobe:masterfrom le717:remove-more-deprecated
Conversation
adobe/brackets@/1ec5c8f8c70dc4aed5e98e3254904a2e8a55ae48
57d2628 While these exports were technically never deprecated, they were never documented either, so it's probably not know they still exist.
Remove even more deprecated code
|
Even after @dangoor's PR #9747, it looks like the removals here will break about 20 different extensions. I think we may want to revert some of these changes for 1.0, since some of the removed items (e.g. @ingorichter remember when reviewing stuff like this that it's always easy to search across all extensions using Kevin's Extension Grabber utility. The search results come back pretty fast, especially if you exclude 'node_modules' folders from the search... |
|
I also strongly recommend The Silver Searcher because it's startlingly fast. Just a few seconds to search through all of the extension code. |
|
It looks like it's just the keyEvent change that needs to be brought back. We should do that in a PR against the release branch. |
|
I goofed again. sigh Sorry guys. facepalm For notes, I have been using the Extension Grabber (and updating the downloads before making changes) and AstroGrep (it's on SourceForge), but it must be missing stuff. I'll try the Silver Searcher on the other PRs once more. |
Even more for #8751.
I did a through scrub of the code base, looking for any pre-0.41 deprecated. I found what I was looking for.
The following is removed with this PR, listed along side the commit they were deprecated with and the release that deprecation went into effect.
command/Commands.jsandcommand/Menus.js: Old export redirects (56ab3e9, Sprint 39)editor/Editor.js: jQuerytriggerHandlerfor"keyEvent"(21bea9d, Sprint 38)search/QuickOpen.js: Backwards compatibility foraddQuickOpenPlugin()(1ec5c8f, Sprint 23)search/QuickOpen.js: Old export redirects (7d262804728, Sprint 19!) These were technically never deprecated, but they are also not documented either.Few notes:
672c7e(utils/StringMatch.js), which landed in Sprint 25. I did not remove it for fear of breaking it because I do not know how that code works. Again, never deprecated, but it seems it was planned to be. @dangoor Since you made this commit, can you provide some insight here on what should be done?