Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR will trigger a minor release when merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
GET /sites/by-tier/:tieradmin endpoint to list sites enrolled at a given entitlement tier (PAID,FREE_TRIAL, orPLG), with optionalproductCodequery parameter (e.g.LLMO) to narrow the result.getAllByEnrollmentAndTiercallsSite.allByEnrollmentAndTier(tier, productCode)(admin-only viahasAdminAccess()), validates tier againstCUSTOMER_VISIBLE_TIERS, and serializes viaSiteDto.src/routes/index.jsand grantssite:readcapability for S2S consumers insrc/routes/required-capabilities.js.tierpath parameter +productCodequery parameter in the OpenAPI specs, with a 400 response example.@adobe/spacecat-shared-data-accessto expose the new model method.resolveWwwUrlmock to three nestedesmockblocks intest/controllers/plg/plg-onboarding.test.jsso admin/Slack-notification/admin-update tests no longer time out (pre-existing failure onmain).Related Issues
SITES-43769
Test plan
productCode)GET /sites/by-tier/:tieris registeredrouteRequiredCapabilitiescoverage assertion passesnpm run docs:lintpasses