Update dependency @embroider/addon-shim to ^1.8.9#378
Merged
NullVoxPopuli merged 7 commits intoadopted-ember-addons:masterfrom Jun 27, 2024
Merged
Update dependency @embroider/addon-shim to ^1.8.9#378NullVoxPopuli merged 7 commits intoadopted-ember-addons:masterfrom
@embroider/addon-shim to ^1.8.9#378NullVoxPopuli merged 7 commits intoadopted-ember-addons:masterfrom
Conversation
@embroider to ^1.0.0@embroider to ^1.0.0
Collaborator
|
I sent this via DM, but for others, here is the plan: I would do this series of PRs:
4 prs in total |
This was referenced Jun 25, 2024
@embroider to ^1.0.0@embroider/addon-shim: ^1.0.0 as dependency
NullVoxPopuli
approved these changes
Jun 27, 2024
Collaborator
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Why use old range || new range?
Contributor
Author
not sure, if there is something braking between v0.50 and 1.x... but we can also remove v0.50 if you want |
Collaborator
|
I don't think anything would break, unless folks are pinning the older versions, which it's their own fault at that point |
@embroider/addon-shim: ^1.0.0 as dependency@embroider/addon-shim: to ^1.0.0
@embroider/addon-shim: to ^1.0.0@embroider/addon-shim to ^1.0.0
@embroider/addon-shim to ^1.0.0@embroider/addon-shim to ^1.8.9
NullVoxPopuli
approved these changes
Jun 27, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #377