Skip to content

Drop support for Ember < 3.28 and reapply "import service instead of inject from '@ember/service'"#421

Merged
mansona merged 2 commits intomasterfrom
ember-versions
Mar 25, 2026
Merged

Drop support for Ember < 3.28 and reapply "import service instead of inject from '@ember/service'"#421
mansona merged 2 commits intomasterfrom
ember-versions

Conversation

@mansona
Copy link
Copy Markdown
Contributor

@mansona mansona commented Mar 24, 2026

This reapplies #415 which should have been a breaking change and should have dropped support for Ember < 3.28 👍

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 24, 2026

Warning

Rate limit exceeded

@mansona has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 3 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 890c0f29-bd16-473d-937a-216c9eb95d86

📥 Commits

Reviewing files that changed from the base of the PR and between 5f8ebe9 and 377b917.

📒 Files selected for processing (13)
  • .github/workflows/ci.yml
  • README.md
  • ember-moment/src/helpers/-base.js
  • test-app-3.x/app/controllers/index.js
  • test-app-3.x/app/routes/application.js
  • test-app-3.x/app/routes/index.js
  • test-app-3.x/config/ember-try.js
  • test-app-4.x/app/controllers/index.js
  • test-app-4.x/app/routes/application.js
  • test-app-4.x/app/routes/index.js
  • test-app-5.x/app/controllers/index.js
  • test-app-5.x/app/routes/application.js
  • test-app-5.x/app/routes/index.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ember-versions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mansona mansona merged commit f20e7f0 into master Mar 25, 2026
20 checks passed
@github-actions github-actions Bot mentioned this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants