Skip to content

6.7.0 release#1010

Merged
juliannguyen4 merged 235 commits intostagefrom
dev
Apr 28, 2026
Merged

6.7.0 release#1010
juliannguyen4 merged 235 commits intostagefrom
dev

Conversation

@juliannguyen4
Copy link
Copy Markdown
Collaborator

@juliannguyen4 juliannguyen4 commented Apr 21, 2026

Changes in addition to ones made in 8.1.2 feature PR's

  • CI/CD: Allow selecting the bump type when bumping the dev number after a release version
  • Add back script to delete .node files that aren't relevant to the user's platform. This is a temporary fix until we start using an S3 bucket
  • While working on this release, I started noticing the tests were running out of order in mocha. This caused the admin test cases to fail because they depended on the ordering of the test cases. So for admin.ts, I changed the test cases so that they can run independently of each other
  • admin.ts: add skipAll helper to avoid conflicting with beforeEach fixtures

TODO

  • Script doesn't seem to trigger on test-ee
  • Metrics client version test is failing; suspect that the wrong JFrog build is being pulled
  • If no longer using tsx, remove from package.json and lock file
  • Confirmed locally that the memory error from metrics.cc also happens on node.js client v6.6.0 using the tests from latest dev here and server 8.1.1. This means the memory error wasn't introduced in v6.7.0, but we need to add this error to a suppressions file for now

Known Issues

  • all_children_with_filter context doesn't accept expressions as a base64 encoded string
  • Path expression mapKeysIn is returning a server error

Out of scope

  • Valgrind maybe could run "#slow" tests if we increase mocha's default timeout from 2 seconds
  • CI/CD: generating type definition file from js source code
  • macOS self hosted runners fails to clean up files properly outside a checked out repo

…need to set this attribute and as_query.ops will be set behind the scenes. This will enable bin projection if they call foreach/results()
…d still figuring out how the test generators work
…ys want to bump the version in a feature branch i.e in dev-workflow.yml..
…t a registry name to pull images from for better flexibility
…e one package.json for all package and dev dependencies. I believe this should work since if there's no package.json in ts-test, it will move up to the repo's root dir which does have the dev dependencies.
…les the typescript tests in ts-test/, and we shouldn't compile any typescript outside ts-test/ in order to run the tests
…lient on a specific platform. This is to save energy
…odules folder. So we don't need to use npx here.
…sense, assuming aerospike module is not installed in the repo's node_modules/ folder.
…aths, use tsc-alias to replace all of whem with relative paths in the compiled js files. Otherwise, node.js will just look for aerospike in node_modules which only contains dependencies.
…sed, and they were exclusively in ts-test/package.json so add them to the root-level package json
… commit and this package weren't in the top level package json and I could still compile the ts tests...?
…pike module test instead of the actual client"

This reverts commit 4295c97.
…spike module test instead of the actual client".

The CI/CD results confirm that the test code is importing the aerospike.ts test file instead of the node.js client.

This reverts commit 843177b.
…find the .js files that map to the .ts files
… replace all the aerospike imports with relative imports
…s sense. That way tsc can validate the tests are using the node.js client properly as well as actually import the client at runtime
juliannguyen4 and others added 20 commits April 26, 2026 09:57
…se flags will be reset for future test cases
…ntain permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…d to specify the exact tag from artifact.aerospike.io
@juliannguyen4 juliannguyen4 marked this pull request as ready for review April 27, 2026 21:22
Copy link
Copy Markdown
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are okay on first review. Let's have a debrief on all of the tech debt fixes that were needed for this after release.

Copy link
Copy Markdown
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good

@juliannguyen4 juliannguyen4 merged commit f6d5207 into stage Apr 28, 2026
622 of 689 checks passed
juliannguyen4 added a commit that referenced this pull request Apr 28, 2026
Add support for server 8.1.2 features:
- Creating set indexes via the client API
- Bin projection
- Path expressions quality of life enhancements

Changes in addition to ones made in 8.1.2 feature PR's

- CI/CD: Allow selecting the bump type when bumping the dev number after a release version
Add back script to delete .node files that aren't relevant to the user's platform. This is a temporary fix until we start using an S3 bucket
- While working on this release, I started noticing the tests were running out of order in mocha. This caused the admin test cases to fail because they depended on the ordering of the test cases. So for admin.ts, I changed the test cases so that they can run independently of each other
- admin.ts: add skipAll helper to avoid conflicting with beforeEach fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants