Handle missing branches in BinOp#392
Merged
agronholm merged 3 commits intoagronholm:masterfrom Sep 3, 2023
Merged
Conversation
vthemelis
force-pushed
the
invalid-bin-op
branch
2 times, most recently
from
c006bf4 to
0238b69
Compare
vthemelis
commented
Aug 28, 2023
vthemelis
force-pushed
the
invalid-bin-op
branch
2 times, most recently
from
5b5f91f to
3110a50
Compare
vthemelis
force-pushed
the
invalid-bin-op
branch
from
3110a50 to
15715c3
Compare
agronholm
reviewed
Sep 3, 2023
agronholm
reviewed
Sep 3, 2023
agronholm
reviewed
Sep 3, 2023
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384 .
The issue is due to the
leftorrightattributes ofBinOpin the case that theAnnotationTransformerevaluates any of them to beNone.The code that removes the attributes completely is:
https://github.com/python/cpython/blob/e407cea1938b80b1d469f148a4ea65587820e3eb/Lib/ast.py#L493-L498
This patch removes the crush but I think shows another bug where in the test I added, the argument
Ais expected to only have a value ofNone. NB that this is not just wrong but also inconsistent with what happens when usingUnioninstead of|