Skip to content

Prefer const over let #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmadnassri merged 1 commit into from
Nov 6, 2018
Merged

Prefer const over let #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const valid = require('./fixtures/har/valid')
const validate = require('../lib/async')

tap.test('async', assert => {
let keys = Object.keys(schemas).filter(key => key !== 'default')
const keys = Object.keys(schemas).filter(key => key !== 'default')

assert.plan(keys.length)

Expand All @@ -20,7 +20,7 @@ tap.test('async', assert => {
tap.test('failure', assert => {
assert.plan(4)

let error = new HARError([{ dataPath: '.log.version', message: 'should be string' }])
const error = new HARError([{ dataPath: '.log.version', message: 'should be string' }])

assert.notOk(validate.har({}), 'should fail')

Expand Down
2 changes: 1 addition & 1 deletion test/promise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const tap = require('tap')
const validate = require('../lib/promise')

tap.test('promises', assert => {
let keys = Object.keys(schemas).filter((key) => key !== 'default')
const keys = Object.keys(schemas).filter((key) => key !== 'default')

assert.plan((keys.length * 2) + 2)

Expand Down
⚡