Skip to content

[Dubbo-3361] Make DubboAppender extends from FileAppender (#3383)#3

Merged
ahugeStone merged 1 commit intoahugeStone:masterfrom
apache:master
Jan 30, 2019
Merged

[Dubbo-3361] Make DubboAppender extends from FileAppender (#3383)#3
ahugeStone merged 1 commit intoahugeStone:masterfrom
apache:master

Conversation

@ahugeStone
Copy link
Copy Markdown
Owner

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@ahugeStone ahugeStone merged commit e34ce83 into ahugeStone:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants