Skip to content

Allows passing size or custom alphabet via cli as args#334

Merged
ai merged 2 commits into
ai:mainfrom
vitalybaev:feature/cli-args
Jan 16, 2022
Merged

Allows passing size or custom alphabet via cli as args#334
ai merged 2 commits into
ai:mainfrom
vitalybaev:feature/cli-args

Conversation

@vitalybaev

Copy link
Copy Markdown
Contributor

Closes #275

I've implemented minimal args parsing logic to fit our needs and be as little as possible

Comment thread bin/parseArgs.js
@ai

ai commented Jan 15, 2022

Copy link
Copy Markdown
Owner

We need to improve test coverage. You can check test coverage locally by running pnpm test.

@ai

ai commented Jan 15, 2022

Copy link
Copy Markdown
Owner

We also need to fix Node.js 12 support for binary (we can’t use ??)

@vitalybaev

Copy link
Copy Markdown
Contributor Author

Done

I've faced error ERROR dual-publish error: Rename bin/utils.js to bin/utils/index.js, so I moved file according to this message.

Now it still works with Node 12 and test coverage is 100%

@ai ai merged commit 32b9bda into ai:main Jan 16, 2022
@vitalybaev vitalybaev deleted the feature/cli-args branch January 16, 2022 14:06
@ai

ai commented Jan 16, 2022

Copy link
Copy Markdown
Owner

bin/utils will create unnecessary files because of dual-publish. I cleaned up arguments parsing a little 27eaa90

And released in 3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI Improvements

2 participants