Skip to content

Rework source map#29

Merged
aidenybai merged 3 commits intoaidenybai:source-mapfrom
lxsmnsyc:source-map-2
Feb 8, 2025
Merged

Rework source map#29
aidenybai merged 3 commits intoaidenybai:source-mapfrom
lxsmnsyc:source-map-2

Conversation

@lxsmnsyc
Copy link
Copy Markdown
Contributor

@lxsmnsyc lxsmnsyc commented Feb 8, 2025

  • We'll be using error-stack-parser-es and source-map-js
  • Since React 19 drops __debugSource, the implementation will always be inaccurate (known issue, see facebook/react for similar issues or just test RDT's source inaccuracy)

Related:

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 8, 2025

⚠️ No Changeset found

Latest commit: d114965

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bippy ❌ Failed (Inspect) Feb 8, 2025 11:06am

@lxsmnsyc
Copy link
Copy Markdown
Contributor Author

lxsmnsyc commented Feb 8, 2025

Screenshot 2025-02-08 at 5 40 16 PM

image

Example inaccuracy of RDT. If we want 100% accuracy, we need Babel transform

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 8, 2025

Open in Stackblitz

npm i https://pkg.pr.new/bippy@29

commit: d114965

@aidenybai aidenybai merged commit 983a86e into aidenybai:source-map Feb 8, 2025
aidenybai added a commit that referenced this pull request Feb 8, 2025
#28)

* refactor(core.ts): add getFiberSource function and update dependencies

* Rework source map (#29)

* Rework source map

* Update inspect.tsx

* Fix deps

* patch

* refactor(bippy): Remove console logs from inspect.tsx

* refactor(bippy): Remove unused import and code in inspect.tsx

---------

Co-authored-by: Alexis H. Munsayac <alexis.munsayac@gmail.com>
@lxsmnsyc lxsmnsyc deleted the source-map-2 branch February 9, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants