Skip to content

[ENH] Add a Filter to tar.extractall Method#6770

Merged
khsrali merged 9 commits into
aiidateam:mainfrom
jgyasu:tar-filter
Apr 23, 2025
Merged

[ENH] Add a Filter to tar.extractall Method#6770
khsrali merged 9 commits into
aiidateam:mainfrom
jgyasu:tar-filter

Conversation

@jgyasu
Copy link
Copy Markdown
Contributor

@jgyasu jgyasu commented Feb 23, 2025

Fixes #6657

This PR adds the data filter to the tar.extractall method such that it does not raise a depreciation warning if the Python version >= 3.12.

@jgyasu
Copy link
Copy Markdown
Contributor Author

jgyasu commented Feb 23, 2025

@danielhollas Hi, I have worked on the issue #6657 and I will appreciate any review :)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (9fe8d50) to head (4489fdd).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
...da/storage/sqlite_zip/migrations/legacy_to_main.py 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6770      +/-   ##
==========================================
- Coverage   78.29%   78.29%   -0.00%     
==========================================
  Files         566      566              
  Lines       42762    42764       +2     
==========================================
+ Hits        33478    33479       +1     
- Misses       9284     9285       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas danielhollas self-requested a review February 23, 2025 23:45
Copy link
Copy Markdown
Collaborator

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jgyasu thank you! This looks good, just one suggestion.

Codecov reports one uncovered line, but that's because we only collect code coverage for Python 3.9 so that is to be expected.

Comment thread src/aiida/storage/sqlite_zip/migrations/legacy_to_main.py Outdated
Comment thread .github/workflows/nightly.yml
Copy link
Copy Markdown
Collaborator

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided that the tests pass this looks good to me, thanks!

(I don't have the commit bit on this repo, so asking @agoscinski for review as well)

Comment thread src/aiida/storage/sqlite_zip/migrations/legacy_to_main.py
@khsrali khsrali merged commit b95fd21 into aiidateam:main Apr 23, 2025
14 of 15 checks passed
@khsrali
Copy link
Copy Markdown
Collaborator

khsrali commented Apr 23, 2025

Thanks @jgyasu, to proceed faster, I had to apply the changes myself.

Note: codecov is failing, only because it's not smart enough.
The test suit has passed --and is going to run every time-- for python version below 3.12 as well.
Therefore I skip on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TarFile.extract raises DeprecationWarning since Python 3.12

3 participants