[ENH] Add a Filter to tar.extractall Method#6770
Conversation
|
@danielhollas Hi, I have worked on the issue #6657 and I will appreciate any review :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6770 +/- ##
==========================================
- Coverage 78.29% 78.29% -0.00%
==========================================
Files 566 566
Lines 42762 42764 +2
==========================================
+ Hits 33478 33479 +1
- Misses 9284 9285 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
left a comment
There was a problem hiding this comment.
Hi @jgyasu thank you! This looks good, just one suggestion.
Codecov reports one uncovered line, but that's because we only collect code coverage for Python 3.9 so that is to be expected.
danielhollas
left a comment
There was a problem hiding this comment.
Provided that the tests pass this looks good to me, thanks!
(I don't have the commit bit on this repo, so asking @agoscinski for review as well)
|
Thanks @jgyasu, to proceed faster, I had to apply the changes myself. Note: codecov is failing, only because it's not smart enough. |
Fixes #6657
This PR adds the
datafilter to thetar.extractallmethod such that it does not raise a depreciation warning if the Python version >= 3.12.