Add dedicated path type throughout the codebase#6819
Closed
ayushjariyal wants to merge 5 commits into
Closed
Conversation
fda4f96 to
5c0aa38
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6819 +/- ##
==========================================
- Coverage 78.31% 78.30% -0.01%
==========================================
Files 566 567 +1
Lines 42762 42771 +9
==========================================
+ Hits 33484 33486 +2
- Misses 9278 9285 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khsrali
requested changes
Apr 23, 2025
Collaborator
khsrali
left a comment
There was a problem hiding this comment.
Thanks @ayushjariyal
Overall looks good!
Please also unify TransportPath with this new path.
3d82169 to
a4612c2
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #6814
In this PR, I introduce a unified
PathTypealias inaiida/common/types.pyto replace inconsistent path-like annotations.This improves consistency and readability.