Skip to content

Docker: fix relative paths, required after upgrade to bake-action@v6#6835

Closed
khsrali wants to merge 1 commit into
aiidateam:mainfrom
khsrali:docker-fix
Closed

Docker: fix relative paths, required after upgrade to bake-action@v6#6835
khsrali wants to merge 1 commit into
aiidateam:mainfrom
khsrali:docker-fix

Conversation

@khsrali
Copy link
Copy Markdown
Collaborator

@khsrali khsrali commented Apr 24, 2025

Solving stupid backward non-compatible errors of docker after upgrade.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.29%. Comparing base (48bd2ac) to head (663ea79).
Report is 63 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6835   +/-   ##
=======================================
  Coverage   78.29%   78.29%           
=======================================
  Files         566      566           
  Lines       42764    42764           
=======================================
  Hits        33479    33479           
  Misses       9285     9285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khsrali khsrali requested a review from Copilot April 24, 2025 10:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Docker workflow configuration to fix relative paths after upgrading to bake-action v6. Key changes include switching from using "workdir: .docker/" to "source: ." and updating file paths for docker build files from "docker-bake.hcl" and "build.json" to ".docker/docker-bake.hcl" and ".docker/build.json".

Files not reviewed (1)
  • .docker/docker-bake.hcl: Language not supported

@khsrali khsrali requested a review from unkcpz April 24, 2025 10:11
@unkcpz
Copy link
Copy Markdown
Member

unkcpz commented Apr 24, 2025

Thanks.

The problem was sourced from https://github.com/docker/bake-action/releases/tag/v6.0.0 where the action start to use git_context. @khsrali could you give it a try?

If using path context, with the change you did, I guess it will break the local build flow as documented in the readme https://github.com/aiidateam/aiida-core/tree/main/.docker#aiida-docker-stacks. Those commands are supposed to run from inside the .docker folder.

@khsrali
Copy link
Copy Markdown
Collaborator Author

khsrali commented Apr 25, 2025

If using path context, with the change you did, I guess it will break the local build flow as documented in the readme https://github.com/aiidateam/aiida-core/tree/main/.docker#aiida-docker-stacks. Those commands are supposed to run from inside the .docker folder.

Good point, wasn't aware of that

@khsrali khsrali force-pushed the docker-fix branch 5 times, most recently from 564526b to 663ea79 Compare April 25, 2025 09:22
@khsrali
Copy link
Copy Markdown
Collaborator Author

khsrali commented Apr 25, 2025

not working.
Either we have to change our documentation or revert to previous version.
#6838

@khsrali
Copy link
Copy Markdown
Collaborator Author

khsrali commented Apr 25, 2025

No time to dig into this.
Low priority..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants