Doc: Fixing doc references after click 8.2 release#6880
Merged
Conversation
`click` released v8.2.0 and by that broke the references to their doc. `click` only keeps one version of the documentation so we cannot reference a different API. Thus we reference the functions by the GitHub link for v8.1.0.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6880 +/- ##
==========================================
- Coverage 78.59% 78.59% -0.00%
==========================================
Files 567 567
Lines 43092 43092
==========================================
- Hits 33866 33864 -2
- Misses 9226 9228 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
unkcpz
approved these changes
May 20, 2025
Member
|
Based on the fact that we pinned the click==8.1, this is a valid change. |
Collaborator
Author
|
Note that in the commit message I misunderstood the EDIT: The |
Closed
agoscinski
added a commit
to agoscinski/aiida-core
that referenced
this pull request
May 22, 2025
`click` released v8.2.0 and by that broke the references to their doc. We pinned `click~=8.1` so we still need to reference the old API but because `click` only keeps one version of the documentation, we cannot reference a different API. Thus we reference the functions by the GitHub link for v8.1.0. Cherry-pick: 5168032
agoscinski
added a commit
that referenced
this pull request
May 22, 2025
`click` released v8.2.0 and by that broke the references to their doc. We pinned `click~=8.1` so we still need to reference the old API but because `click` only keeps one version of the documentation, we cannot reference a different API. Thus we reference the functions by the GitHub link for v8.1.0. Cherry-pick: 5168032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clickreleased v8.2.0 and by that broke the references to their doc.clickonly keeps one version of the documentation so we cannot reference a different API. Thus we reference the functions by the GitHub link for v8.1.0.