Add root flag to verdi process list#7270
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7270 +/- ##
===========================================
- Coverage 79.75% 29.97% -49.78%
===========================================
Files 566 566
Lines 43897 43871 -26
===========================================
- Hits 35006 13144 -21862
- Misses 8891 30727 +21836 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @r0hansaxena. Looks good so far 💪 One note regarding your tests - we currently consolidate all UpdateYour tests failed (also the pre-commit) 🥲 Please try to resolve this. You can of course ping me if you need assistance 🙂 |
edan-bainglass
left a comment
There was a problem hiding this comment.
Thanks @r0hansaxena. Left a couple of comments. Also, are you running tests locally to make sure everything passes on your end?
|
Heya, just a quick question, should we bikeshed the name of the option a bit? Is |
thanks! the core listing and sql tests are passing fine on my end. |
|
I have also fixed the linting issues, I'll make changes if necessary after the checks are done running once again accordingly. |
|
I do agree, |
001effd to
b1d0de1
Compare
|
the ci checks are failing, I'll address the issues and make the necessary changes |
f0bd0b1 to
51cea1c
Compare
51cea1c to
1cad40c
Compare
Add edge_filter_dict parameter to recursive join method.
Thanks @danielhollas. Though I agree that @r0hansaxena please hold off on updating this part until we reach a consensus 🙂 |
|
Still failing 🥲 Have a look. |
yes, I have made changes, it should work fine this time |
i will address the failing ci checks again |
|
Please first verify the tests locally, you can run them as uv run pytest -m presto -n auto |
- Remove -r shorthand for --roots to avoid conflict with --raw - Fix LinkType import in calculation.py to avoid AttributeError in tests - Add subquery in CalculationQueryBuilder to correctly filter out non-root processes without interfering with generate_joins() logic - Fix test_list counts to match new expectations - Add -r flag to all --roots tests in test_list to verify just data lines - Moved link.add_incoming before node.store() in tests to respect AiiDA checks
yes, I have been working on the same, I'll update it here |
Looking at the current options ( |
Summary
Adds a
--rootflag toverdi process listto filter for root processes — processes that have no caller and were submitted directly by the user rather than spawned by another process.Closes #7170
Motivation
When working with large workflow histories, it can be difficult to identify which processes are top-level entries vs. sub-processes spawned inside a workflow. This flag makes it easy to list only the "entry points".
Changes
ROOToverridable CLI option.--rootinto theprocess_listcommand.CALL_CALCandCALL_WORKlinks, filtering for nodes where no caller exists.--all.Usage