Strict typing for aiida.brokers module#7307
Merged
Merged
Conversation
danielhollas
force-pushed
the
typing/broker
branch
from
8a6a66c to
6086d05
Compare
danielhollas
commented
Mar 29, 2026
| self.close() | ||
|
|
||
| def iterate_tasks(self): | ||
| def iterate_tasks(self) -> Iterator[t.Any]: |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately kiwipy is not typed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7307 +/- ##
==========================================
+ Coverage 79.85% 79.85% +0.01%
==========================================
Files 566 566
Lines 43941 43947 +6
==========================================
+ Hits 35084 35091 +7
+ Misses 8857 8856 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GeigerJ2
approved these changes
Mar 31, 2026
Collaborator
GeigerJ2
left a comment
GeigerJ2
left a comment
There was a problem hiding this comment.
LGTM, thanks @danielhollas!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the changes here are only to method annotations and are quite straightforward