🐛 Fix RabbitMQ probe cleanup on Python 3.14 by agoscinski · Pull Request #7342 · aiidateam/aiida-core

agoscinski · 2026-04-28T11:19:40Z

Should fix issues when trying to connect to RMQ. This fix is not related to ZMQ but the problem became more pressing because in verdi presto we first try to connect to RMQ and if its not available

❮ verdi presto
Report: Option `--use-postgres` not enabled: configuring the profile to use SQLite.
error when creating transport: <AMQPConnectionError: (61, "Connect call failed ('127.0.0.1', 5672)")>
Report: RabbitMQ server not found: falling back to ZMQ broker.
Warning: The ZMQ broker is a new feature. If you experience issues, recreate the profile with `verdi presto --no-broker`.
Exception ignored while calling deallocator <function Connection.__del__ at 0x105a44ca0>:
Traceback (most recent call last):
  File "/Users/mbercx/.aiida_venvs/qe-test/lib/python3.14/site-packages/aio_pika/connection.py", line 215, in __del__
    asyncio.ensure_future(self.close())
  File "/Users/mbercx/.local/share/uv/python/cpython-3.14.4-macos-aarch64-none/lib/python3.14/asyncio/tasks.py", line 730, in ensure_future
    loop = events.get_event_loop()
  File "/Users/mbercx/.local/share/uv/python/cpython-3.14.4-macos-aarch64-none/lib/python3.14/asyncio/events.py", line 715, in get_event_loop
    raise RuntimeError('There is no current event loop in thread %r.'
RuntimeError: There is no current event loop in thread 'MainThread'.
/Users/mbercx/.aiida_venvs/qe-test/lib/python3.14/site-packages/alembic/operations/base.py:27: RuntimeWarning: coroutine 'RobustConnection.close' was never awaited
  from . import batch
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
Report: Initialising the storage backend.
Report: Migrating to the head of the main branch
Report: Storage initialisation completed.
Success: Created new profile `presto`.
Success: Configured the localhost as a computer.

First commit fixes the RobustConnection.close. Second commit surpresses the error when creating transport: <AMQPConnectionError: (61, "Connect call failed ('127.0.0.1', 5672)")>

This PR replaces probably PR #7328 but need to verify.

Probe RabbitMQ connection parameters in an isolated event loop and close the temporary aio-pika connection explicitly, even when the connection attempt fails.

This avoids the Python 3.14 cleanup warning emitted by aio-pika's Connection.del when verdi presto falls back from a failed RabbitMQ probe to the ZMQ broker.

Add regression coverage for the failed probe path and verify that it no longer emits the ignored deallocator exception or unawaited coroutine warning.

codecov · 2026-04-28T11:22:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.25%. Comparing base (282fd72) to head (0271f90).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7342      +/-   ##
==========================================
+ Coverage   80.23%   80.25%   +0.02%     
==========================================
  Files         577      577              
  Lines       45478    45502      +24     
==========================================
+ Hits        36487    36515      +28     
+ Misses       8991     8987       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Probe RabbitMQ connection parameters in an isolated event loop and close the temporary aio-pika connection explicitly, even when the connection attempt fails. This avoids the Python 3.14 cleanup warning emitted by aio-pika's Connection.__del__ when verdi presto falls back from a failed RabbitMQ probe to the ZMQ broker. Add regression coverage for the failed probe path and verify that it no longer emits the ignored deallocator exception or unawaited coroutine warning.

Temporarily raise the aiormq and aio-pika logger levels while probing RabbitMQ connection parameters. The failed probe path is expected during verdi presto fallback, so the transport creation error should not be shown before the CLI reports that it is switching to the ZMQ broker. Extend the subprocess regression test to verify that the noisy transport log is no longer emitted alongside the Python 3.14 cleanup warnings.

Move aio_pika imports from module level into _probe_rabbitmq_connection() to avoid loading aio_pika on every verdi invocation, since BROKER_DEFAULTS is imported at module level by CLI options.

GeigerJ2

OK, only one very nitpicky comment. Apart from that, you have pleased the pedantic review agent. Good job!

GeigerJ2 · 2026-04-30T09:29:32Z

@@ -40,8 +86,6 @@ def detect_rabbitmq_config(
    :raises ConnectionError: If the connection failed with the provided connection parameters
    :returns: The connection parameters if the RabbitMQ server was successfully connected to, or ``None`` otherwise.


Pre-existing, but since the PR modifies this function: the docstring says "or None otherwise" but the function never returns None. It raises ConnectionError on failure (which all three callers — cmd_presto.py:242, cmd_profile.py:85, cmd_profile.py:174 — explicitly catch). The return type annotation -> dict[str, t.Any] is correct. Suggested fix:

:returns: The connection parameters with keys prefixed with ``broker_``.

Probe RabbitMQ connection parameters in an isolated event loop and close the temporary aio-pika connection explicitly, even when the connection attempt fails. This avoids the Python 3.14 cleanup warning emitted by aio-pika's Connection.__del__ when verdi presto falls back from a failed RabbitMQ probe to the ZMQ broker. Add regression coverage for the failed probe path and verify that it no longer emits the ignored deallocator exception or unawaited coroutine warning.

Temporarily raise the aiormq and aio-pika logger levels while probing RabbitMQ connection parameters. The failed probe path is expected during verdi presto fallback, so the transport creation error should not be shown before the CLI reports that it is switching to the ZMQ broker. Extend the subprocess regression test to verify that the noisy transport log is no longer emitted alongside the Python 3.14 cleanup warnings.

Move aio_pika imports from module level into _probe_rabbitmq_connection() to avoid loading aio_pika on every verdi invocation, since BROKER_DEFAULTS is imported at module level by CLI options.

agoscinski · 2026-04-30T13:08:41Z

@@ -40,8 +86,6 @@ def detect_rabbitmq_config(
    :raises ConnectionError: If the connection failed with the provided connection parameters
    :returns: The connection parameters if the RabbitMQ server was successfully connected to, or ``None`` otherwise.


Suggested change

:returns: The connection parameters if the RabbitMQ server was successfully connected to, or ``None`` otherwise.

:returns: The connection parameters with keys prefixed with ``broker_``.

Probe RabbitMQ connection parameters in an isolated event loop and close the temporary aio-pika connection explicitly, even when the connection attempt fails. This avoids the Python 3.14 cleanup warning emitted by aio-pika's Connection.__del__ when verdi presto falls back from a failed RabbitMQ probe to the ZMQ broker. Add regression coverage for the failed probe path and verify that it no longer emits the ignored deallocator exception or unawaited coroutine warning.

Temporarily raise the aiormq and aio-pika logger levels while probing RabbitMQ connection parameters. The failed probe path is expected during verdi presto fallback, so the transport creation error should not be shown before the CLI reports that it is switching to the ZMQ broker. Extend the subprocess regression test to verify that the noisy transport log is no longer emitted alongside the Python 3.14 cleanup warnings.

Move aio_pika imports from module level into _probe_rabbitmq_connection() to avoid loading aio_pika on every verdi invocation, since BROKER_DEFAULTS is imported at module level by CLI options.

Probe RabbitMQ connection parameters in an isolated event loop and close the temporary aio-pika connection explicitly, even when the connection attempt fails. This avoids the Python 3.14 cleanup warning emitted by aio-pika's Connection.__del__ when verdi presto falls back from a failed RabbitMQ probe to the ZMQ broker. Add regression coverage for the failed probe path and verify that it no longer emits the ignored deallocator exception or unawaited coroutine warning.

Temporarily raise the aiormq and aio-pika logger levels while probing RabbitMQ connection parameters. The failed probe path is expected during verdi presto fallback, so the transport creation error should not be shown before the CLI reports that it is switching to the ZMQ broker. Extend the subprocess regression test to verify that the noisy transport log is no longer emitted alongside the Python 3.14 cleanup warnings.

Move aio_pika imports from module level into _probe_rabbitmq_connection() to avoid loading aio_pika on every verdi invocation, since BROKER_DEFAULTS is imported at module level by CLI options.

Probe RabbitMQ connection parameters in an isolated event loop and close the temporary aio-pika connection explicitly, even when the connection attempt fails. This avoids the Python 3.14 cleanup warning emitted by aio-pika's Connection.__del__ when verdi presto falls back from a failed RabbitMQ probe to the ZMQ broker. Add regression coverage for the failed probe path and verify that it no longer emits the ignored deallocator exception or unawaited coroutine warning. Reviewed-by: Julian Geiger <julian.geiger@psi.ch>

Temporarily raise the aiormq and aio-pika logger levels while probing RabbitMQ connection parameters. The failed probe path is expected during verdi presto fallback, so the transport creation error should not be shown before the CLI reports that it is switching to the ZMQ broker. Extend the subprocess regression test to verify that the noisy transport log is no longer emitted alongside the Python 3.14 cleanup warnings. Reviewed-by: Julian Geiger <julian.geiger@psi.ch>

Move aio_pika imports from module level into _probe_rabbitmq_connection() to avoid loading aio_pika on every verdi invocation, since BROKER_DEFAULTS is imported at module level by CLI options. Reviewed-by: Julian Geiger <julian.geiger@psi.ch>

Probe RabbitMQ connection parameters in an isolated event loop and close the temporary aio-pika connection explicitly, even when the connection attempt fails. This avoids the Python 3.14 cleanup warning emitted by aio-pika's Connection.__del__ when verdi presto falls back from a failed RabbitMQ probe to the ZMQ broker. Add regression coverage for the failed probe path and verify that it no longer emits the ignored deallocator exception or unawaited coroutine warning. Reviewed-by: Julian Geiger <julian.geiger@psi.ch>

Temporarily raise the aiormq and aio-pika logger levels while probing RabbitMQ connection parameters. The failed probe path is expected during verdi presto fallback, so the transport creation error should not be shown before the CLI reports that it is switching to the ZMQ broker. Extend the subprocess regression test to verify that the noisy transport log is no longer emitted alongside the Python 3.14 cleanup warnings. Reviewed-by: Julian Geiger <julian.geiger@psi.ch>

Probe RabbitMQ connection parameters in an isolated event loop and close the temporary aio-pika connection explicitly, even when the connection attempt fails. This avoids the Python 3.14 cleanup warning emitted by aio-pika's Connection.__del__ when verdi presto falls back from a failed RabbitMQ probe to the ZMQ broker. Add regression coverage for the failed probe path and verify that it no longer emits the ignored deallocator exception or unawaited coroutine warning. Reviewed-by: Julian Geiger <julian.geiger@psi.ch>

Temporarily raise the aiormq and aio-pika logger levels while probing RabbitMQ connection parameters. The failed probe path is expected during verdi presto fallback, so the transport creation error should not be shown before the CLI reports that it is switching to the ZMQ broker. Extend the subprocess regression test to verify that the noisy transport log is no longer emitted alongside the Python 3.14 cleanup warnings. Reviewed-by: Julian Geiger <julian.geiger@psi.ch>

Move aio_pika imports from module level into _probe_rabbitmq_connection() to avoid loading aio_pika on every verdi invocation, since BROKER_DEFAULTS is imported at module level by CLI options. Reviewed-by: Julian Geiger <julian.geiger@psi.ch>

agoscinski changed the title ~~🐛 Fix RabbitMQ probe cleanup on Python 3.14 (#7342)~~ 🐛 Fix RabbitMQ probe cleanup on Python 3.14 Apr 28, 2026

agoscinski added this to aiida-core v2.8.1 Apr 28, 2026

agoscinski force-pushed the fix/rmq-autodetect-py314 branch from 25fcc1e to 1039c2d Compare April 29, 2026 08:02

agoscinski force-pushed the fix/rmq-autodetect-py314 branch from 1039c2d to bd1390e Compare April 29, 2026 10:48

agoscinski force-pushed the fix/rmq-autodetect-py314 branch from bd1390e to 5229304 Compare April 30, 2026 05:35

GeigerJ2 approved these changes Apr 30, 2026

View reviewed changes

agoscinski force-pushed the fix/rmq-autodetect-py314 branch from 5229304 to 1a409af Compare April 30, 2026 11:08

agoscinski marked this pull request as ready for review April 30, 2026 11:23

agoscinski commented Apr 30, 2026

View reviewed changes

agoscinski force-pushed the fix/rmq-autodetect-py314 branch from 1a409af to 5539fd5 Compare April 30, 2026 13:11

agoscinski force-pushed the fix/rmq-autodetect-py314 branch from 5539fd5 to c5f7af2 Compare April 30, 2026 13:12

agoscinski added 2 commits April 30, 2026 15:12

agoscinski force-pushed the fix/rmq-autodetect-py314 branch from c5f7af2 to 0271f90 Compare April 30, 2026 13:13

agoscinski merged commit 2491deb into aiidateam:main Apr 30, 2026
7 of 8 checks passed

github-project-automation Bot moved this to Done in aiida-core v2.8.1 Apr 30, 2026

agoscinski deleted the fix/rmq-autodetect-py314 branch April 30, 2026 13:15

agoscinski mentioned this pull request Apr 30, 2026

🐛 Fix RabbitMQ config probe cleanup #7328

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Fix RabbitMQ probe cleanup on Python 3.14#7342

🐛 Fix RabbitMQ probe cleanup on Python 3.14#7342
agoscinski merged 3 commits into
aiidateam:mainfrom
agoscinski:fix/rmq-autodetect-py314

agoscinski commented Apr 28, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

GeigerJ2 left a comment

Uh oh!

GeigerJ2 Apr 30, 2026

Uh oh!

agoscinski Apr 30, 2026

Uh oh!

agoscinski Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -40,8 +86,6 @@ def detect_rabbitmq_config(
		:raises ConnectionError: If the connection failed with the provided connection parameters
		:returns: The connection parameters if the RabbitMQ server was successfully connected to, or ``None`` otherwise.

	:returns: The connection parameters if the RabbitMQ server was successfully connected to, or ``None`` otherwise.
	:returns: The connection parameters with keys prefixed with ``broker_``.

Conversation

agoscinski commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GeigerJ2 left a comment

Choose a reason for hiding this comment

Uh oh!

GeigerJ2 Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

agoscinski Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

agoscinski Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agoscinski commented Apr 28, 2026 •

edited

Loading

codecov Bot commented Apr 28, 2026 •

edited

Loading