🧪 ci-code: unique coverage artifact per broker#7368
Open
GeigerJ2 wants to merge 1 commit into
Open
Conversation
The two py3.14 matrix variants (rmq, zmq) both upload an artifact named `coverage`, which collides under `upload-artifact@v4+`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7368 +/- ##
==========================================
- Coverage 80.28% 80.28% -0.00%
==========================================
Files 577 577
Lines 45545 45545
==========================================
- Hits 36562 36560 -2
- Misses 8983 8985 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khsrali
reviewed
May 15, 2026
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: coverage | ||
| name: coverage-${{ matrix.broker-backend }} |
Collaborator
There was a problem hiding this comment.
@GeigerJ2
Thanks for taking care of this. quick question:
Why do we need to run coverage multiple times in the first place?
the results should be identical, right? or am i missing something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two py3.14 matrix variants (rmq, zmq) both upload an artifact named
coverage, which collides underupload-artifact@v4+.