Skip to content

Python 3.13 support #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 4 commits into from
Sep 9, 2024
Merged

Python 3.13 support #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30f13d3
Python 3.13 support
bdraco Sep 9, 2024
24e3f38
feature
bdraco Sep 9, 2024
ebda8ac
Merge branch 'master' into py313
bdraco Sep 9, 2024
bc700a2
Update .github/workflows/ci-cd.yml
bdraco Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,10 @@ jobs:
strategy:
matrix:
pyver:
- 3.13-dev
- 3.13
- 3.12
- 3.11
- >-
3.10
- "3.10"
- 3.9
- 3.8
no-extensions: ['', 'Y']
Expand Down Expand Up @@ -199,12 +198,7 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.pyver }}
allow-prereleases: >-
Copy link
Copy Markdown
Member

@webknjaz webknjaz Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco this should be kept long-term so that adding -dev things in the future wouldn't require remembering to reimplement it once again.

Copy link
Copy Markdown
Member Author

@bdraco bdraco Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I matched it to yarl since I wasn't sure if 3.13-dev would pull non rc/stable 3.13, and allow-prereleases: true is still needed for 3.13 since its rc

https://github.com/aio-libs/yarl/blob/eaf76414d44e72b022a7dee3b48bb532934a2f33/.github/workflows/ci-cd.yml#L226

Copy link
Copy Markdown
Member Author

@bdraco bdraco Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like keeping -dev will still work https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#specifying-a-python-version

Copy link
Copy Markdown
Member Author

@bdraco bdraco Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert that change

Copy link
Copy Markdown
Member Author

@bdraco bdraco Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized there are other checks for -dev though that we want to be fatal if 3.13 breaks though....so I'm not sure if reverting it makes sense

Copy link
Copy Markdown
Member

@webknjaz webknjaz Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, leave it as is. I usually like using a different syntax ~3.13.0-0 and check for ~ in other places. But I suppose it's not important to figure out right now. Something to remember at some point, perhaps.

I also didn't fully realize that this is about the action input. I typically have this in the check for allowing failures, which is what confused me and I overlooked the context.

${{
endsWith(matrix.pyver, '-dev')
&& true
|| false
}}
allow-prereleases: true
- name: Get pip cache dir
id: pip-cache
run: |
Expand Down
1 change: 1 addition & 0 deletions CHANGES/1002.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added support for Python 3.13 -- by :user:`bdraco`.
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ classifiers =
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
Programming Language :: Python :: 3.13

[options]
python_requires = >= 3.8
Expand Down
⚡