Merged
Conversation
Replace startswith with a single char check
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1137 +/- ##
==========================================
+ Coverage 95.20% 95.22% +0.02%
==========================================
Files 30 30
Lines 4709 4732 +23
Branches 417 419 +2
==========================================
+ Hits 4483 4506 +23
Misses 200 200
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
startswithwith a single char check.startswithis a good choice for multiple chars, but its much slower for single chars.in the path, don't normalize them as there is nothing to do. In testing 80% of paths did not have a.so we would needless normalize themAre there changes in behavior for the user?
no
timeit
startswith: 0.005655332934111357
single char check: 0.0019642498809844255
before
after
