Skip to content

fix(tslint): add correct semicolon option#1777

Merged
nnixaa merged 2 commits intoakveo:masterfrom
eduhenke:patch-1
Jul 24, 2018
Merged

fix(tslint): add correct semicolon option#1777
nnixaa merged 2 commits intoakveo:masterfrom
eduhenke:patch-1

Conversation

@eduhenke
Copy link
Copy Markdown
Contributor

@eduhenke eduhenke commented Jul 9, 2018

The first parameter in the semicolon option in tslint.json should be a boolean.

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

Fixes the typescript linter

eduhenke added 2 commits July 9, 2018 18:10
The first parameter in the semicolon option in tslint.json should be a boolean.
@nnixaa
Copy link
Copy Markdown
Collaborator

nnixaa commented Jul 21, 2018

Hey @eduhenke, so is it correct that it wasn't working properly before this fix and now it checks for the semicolon presence?

@eduhenke
Copy link
Copy Markdown
Contributor Author

@nnixaa yep, exactly :)

@nnixaa
Copy link
Copy Markdown
Collaborator

nnixaa commented Jul 24, 2018

@eduhenke ah, good catch!

@nnixaa nnixaa merged commit 00e6ca5 into akveo:master Jul 24, 2018
nnixaa added a commit that referenced this pull request Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants