Conversation
- Break run_evaluation into focused phase functions (_run_test_metrics, _run_rollout_videos, _run_rollout_metrics, _run_rollout_per_timestep_metrics, _write_final_csvs) to reduce complexity and improve readability - Extract _resolve_metric_fns to eliminate duplicated metric resolution logic between test and rollout metric setup - Unwrap Fabric-wrapped model once and pass unwrapped model to functions that access model internals (parameter counting, benchmarks) instead of relying on Fabric proxy attribute access with pyright ignores - Add depth limit to _unwrap_module to guard against circular wrapper chains - Extract _setup_fabric, _load_model_checkpoint, and _resolve_eval_paths helpers from run_evaluation
Co-authored-by: Radka Jersakova <r.jersakova@gmail.com> Co-authored-by: Paolo Conti <ContiPaolo@users.noreply.github.com>
Co-authored-by: Paolo Conti <ContiPaolo@users.noreply.github.com> Co-authored-by: Radka Jersakova <r.jersakova@gmail.com>
Co-authored-by: Paolo Conti <ContiPaolo@users.noreply.github.com> Co-authored-by: Radka Jersakova <r.jersakova@gmail.com>
Co-authored-by: Radka Jersakova r.jersakova@gmail.com
…generalize MultiEncoder dimensional projections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #308
We have 2 scripts in
notebooks/for the full workflow:generate_reaction_diffusion.pytrain_reaction_diffusion.pyQUESTIONS and TODOs: