[FEATURE] Add community_base_url to salesforce-community connection

[edify42]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #129

Changes proposed in this pull request:

• Added salesforce-community option 'community_base_url' which was missing.
• Also added a salesforce-community test for this confirming it works OK
• Updated the broken twilio test case

Linked issue: #129

Output from acceptance testing:

$ make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v  -timeout 120m -coverprofile="c.out" -run ^".*"
?   	github.com/lendi-au/terraform-provider-auth0	[no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_debugDefaults
=== RUN   TestProvider_debugDefaults/should_be_false_if_no_AUTH0_DEBUG_environment_variable_is_defined
=== RUN   TestProvider_debugDefaults/should_be_true_when_AUTH0_DEBUG_environment_variable_is_set_to_"1"
=== RUN   TestProvider_debugDefaults/should_be_true_when_AUTH0_DEBUG_environment_variable_is_set_to_"true"
=== RUN   TestProvider_debugDefaults/should_be_true_when_AUTH0_DEBUG_environment_variable_is_set_to_"on"
=== RUN   TestProvider_debugDefaults/should_be_false_when_AUTH0_DEBUG_environment_variable_is_set_to_"false"
--- PASS: TestProvider_debugDefaults (0.00s)
    --- PASS: TestProvider_debugDefaults/should_be_false_if_no_AUTH0_DEBUG_environment_variable_is_defined (0.00s)
    --- PASS: TestProvider_debugDefaults/should_be_true_when_AUTH0_DEBUG_environment_variable_is_set_to_"1" (0.00s)
    --- PASS: TestProvider_debugDefaults/should_be_true_when_AUTH0_DEBUG_environment_variable_is_set_to_"true" (0.00s)
    --- PASS: TestProvider_debugDefaults/should_be_true_when_AUTH0_DEBUG_environment_variable_is_set_to_"on" (0.00s)
    --- PASS: TestProvider_debugDefaults/should_be_false_when_AUTH0_DEBUG_environment_variable_is_set_to_"false" (0.00s)
=== RUN   TestAccClientGrant
--- PASS: TestAccClientGrant (7.20s)
=== RUN   TestAccClient
--- PASS: TestAccClient (0.70s)
=== RUN   TestAccConnection
--- PASS: TestAccConnection (7.13s)
=== RUN   TestAccConnectionAd
--- PASS: TestAccConnectionAd (0.46s)
=== RUN   TestAccConnectionWaad
--- PASS: TestAccConnectionWaad (7.15s)
=== RUN   TestAccConnectionWithEnbledClients
--- PASS: TestAccConnectionWithEnbledClients (13.18s)
=== RUN   TestTwilioConnection
--- PASS: TestTwilioConnection (0.48s)
=== RUN   TestSalesforceCommunityConnection
--- PASS: TestSalesforceCommunityConnection (6.42s)
=== RUN   TestAccCustomDomain
--- SKIP: TestAccCustomDomain (0.00s)
    resource_auth0_custom_domain_test.go:12:
=== RUN   TestAccEmailTemplate
--- PASS: TestAccEmailTemplate (6.54s)
=== RUN   TestAccEmail
--- PASS: TestAccEmail (8.00s)
=== RUN   TestAccResourceServer
--- PASS: TestAccResourceServer (0.35s)
=== RUN   TestAccRuleConfig
--- PASS: TestAccRuleConfig (6.30s)
=== RUN   TestAccRule
--- PASS: TestAccRule (0.32s)
=== RUN   TestRuleNameRegexp
--- PASS: TestRuleNameRegexp (0.00s)
=== RUN   TestAccTenant
--- PASS: TestAccTenant (0.29s)
=== RUN   TestAccUserMissingRequiredParams
--- PASS: TestAccUserMissingRequiredParams (0.01s)
=== RUN   TestAccUserCreateUser
--- PASS: TestAccUserCreateUser (6.48s)
=== RUN   TestMapData
--- PASS: TestMapData (0.00s)
PASS
coverage: 77.6% of statements
ok  	github.com/lendi-au/terraform-provider-auth0/auth0	71.043s	coverage: 77.6% of statements

[alexkappa]

Excellent, thank you for submitting the issue and PR! I’ll use this as an example to anyone wishing to contribute :)

[alexkappa]

Thanks for working on this! Lets merge the changes over at auth0/go-auth0 and come back to finalize

[alexkappa]

This will need to be set so it can pass during CI. We’ve enabled “requires username” on this connection a while ago and we require it everywhere.

[edify42]

Thanks @alexkappa - I've added the username back in. Any ideas on how to solve the next CI error "client_secret" is required, but no definition was found.?

[alexkappa]

That is an unfortunate side effect of switching to travis. It seems that PRs don't get access to all secrets for security reasons. I'll need to run it manually I suppose.