Add "auth0_hook" support and missing field on "auth0_client"#171
Add "auth0_hook" support and missing field on "auth0_client"#171alexkappa merged 2 commits intoalexkappa:masterfrom
Conversation
4432818 to
01ef8a2
Compare
|
I can't help it that auth0 rules and auth0 hooks have a very similar syntax and functionality. :) The CodeClimate errors about duplicate code is just because of how similar they are. How can I fix that? |
|
The Travis CI errors seem to all be related to a missing "client_secret" (i.e. the AUTH0_CLIENT_SECRET environment variable). |
|
I think you and I are literally working in tandem on all of this. lol I see my changes being reflected in master. |
You have a point there :) Don't worry about the codeclimate issues too much, I'll do a review and likely they won't be important. And don't worry about the travis build either, I have to run the tests manually as protected env vars are not available to pull requests.
Unfortunately, I beat you to the punch there. My apologies for this, I should have mentioned that I was working on it so you wouldn't have to. We're mid-transition over to terraform-providers/terraform-provider-auth0 and I'm trying to get a hang of having things in two places... I'll make sure to let people know if I'm working on something. Sorry again, and thanks for helping out |
Changes proposed in this pull request:
Output from acceptance testing:
And to prove