Skip to content
This repository was archived by the owner on Mar 8, 2022. It is now read-only.

Add support for OIDC connection strategy#215

Merged
alexkappa merged 10 commits intoalexkappa:masterfrom
politician:support-oidc-connection
May 11, 2020
Merged

Add support for OIDC connection strategy#215
alexkappa merged 10 commits intoalexkappa:masterfrom
politician:support-oidc-connection

Conversation

@politician
Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #212

Changes proposed in this pull request:

  • Support the OIDC connection strategy

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectionOIDC
==> Checking that code complies with gofmt requirements...
?   	github.com/terraform-providers/terraform-provider-auth0	[no test files]
=== RUN   TestAccConnectionOIDC
--- PASS: TestAccConnectionOIDC (6.44s)
PASS
coverage: 10.0% of statements
ok  	github.com/terraform-providers/terraform-provider-auth0/auth0	7.602s	coverage: 10.0% of statements
?   	github.com/terraform-providers/terraform-provider-auth0/auth0/internal/debug	[no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok  	github.com/terraform-providers/terraform-provider-auth0/auth0/internal/random	0.764s	coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok  	github.com/terraform-providers/terraform-provider-auth0/auth0/internal/validation	0.544s	coverage: 0.0% of statements [no tests to run]
?   	github.com/terraform-providers/terraform-provider-auth0/version	[no test files]

@politician politician changed the title Add support for OIDC connection provider. Fixes #212 Add support for OIDC connection provider May 3, 2020
@politician politician changed the title Add support for OIDC connection provider Add support for OIDC connection strategy May 3, 2020
@politician
Copy link
Copy Markdown
Contributor Author

@alexkappa any chance this can be merged soon?

Thank you!

Copy link
Copy Markdown
Owner

@alexkappa alexkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Incorrupt, thanks for submitting this!

It looks really well mostly, I've made some comments on the scope field to use the existing mechanism. Thanks!

@politician
Copy link
Copy Markdown
Contributor Author

@alexkappa I'm stuck on the tests. I get the following:
TestAccConnectionOIDC: testing.go:674: Step 0 error: Check failed: Check 16/17 error: auth0_connection.oidc: Attribute 'options.0.scopes.881205744' not found
How do I find out the right attribute number?

@alexkappa
Copy link
Copy Markdown
Owner

alexkappa commented May 8, 2020 via email

Copy link
Copy Markdown
Owner

@alexkappa alexkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Incorrupt I made some suggestions, I hope it helped you out :)

@politician
Copy link
Copy Markdown
Contributor Author

@alexkappa thanks for the suggestions, they came in handy as I wasn't able to run the debug.DumpAttr() command.
Everything is now passing the tests.

@politician politician closed this May 9, 2020
@politician politician reopened this May 9, 2020
@politician politician requested a review from alexkappa May 9, 2020 04:13
Copy link
Copy Markdown
Owner

@alexkappa alexkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Could you run go mod vendor to vendor deps? Then we’re good to merge!

@politician politician requested a review from alexkappa May 9, 2020 15:13
@alexkappa alexkappa merged commit 67030ff into alexkappa:master May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported connection strategy oidc

2 participants