Add support for OIDC connection strategy#215
Add support for OIDC connection strategy#215alexkappa merged 10 commits intoalexkappa:masterfrom politician:support-oidc-connection
Conversation
|
@alexkappa any chance this can be merged soon? Thank you! |
alexkappa
left a comment
There was a problem hiding this comment.
Hi @Incorrupt, thanks for submitting this!
It looks really well mostly, I've made some comments on the scope field to use the existing mechanism. Thanks!
|
@alexkappa I'm stuck on the tests. I get the following: |
|
Hi Romain, to discover what key to use you can use the debug.DumpAttr()
function from the debug package. Use it as one of your checks and it will
print the entire state.
To view the output, you’ll need to set the TF_LOG=DEBUG env var when
running tests.
…On Fri, 8 May 2020 at 16:11, Romain Barissat ***@***.***> wrote:
@alexkappa <https://github.com/alexkappa> I'm stuck on the tests. I get
the following:
TestAccConnectionOIDC: testing.go:674: Step 0 error: Check failed: Check
16/17 error: auth0_connection.oidc: Attribute 'options.0.scopes.881205744'
not found
How do I find out the right attribute number?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#215 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJF673GFH3CE6KT52X3R53RQQHKBANCNFSM4MYDTCVA>
.
|
alexkappa
left a comment
There was a problem hiding this comment.
Hi @Incorrupt I made some suggestions, I hope it helped you out :)
|
@alexkappa thanks for the suggestions, they came in handy as I wasn't able to run the |
alexkappa
left a comment
There was a problem hiding this comment.
Very nice! Could you run go mod vendor to vendor deps? Then we’re good to merge!
Community Note
Fixes #212
Changes proposed in this pull request:
Output from acceptance testing: