Skip to content
This repository was archived by the owner on Mar 8, 2022. It is now read-only.

Add new identifier_first field to prompt#321

Merged
yvovandoorn merged 1 commit intoalexkappa:masterfrom
kpurdon:kpurdon/add-prompt-identifier-first
Mar 24, 2021
Merged

Add new identifier_first field to prompt#321
yvovandoorn merged 1 commit intoalexkappa:masterfrom
kpurdon:kpurdon/add-prompt-identifier-first

Conversation

@kpurdon
Copy link
Copy Markdown
Contributor

@kpurdon kpurdon commented Jan 21, 2021

Proposed Changes

Pending go-auth0/auth0#187 (will add test output and update here when that is merged/released)

Adds the new identifier_first argument to prompts. I will update the terraform provider as well once this lands and is tagged.

https://support.auth0.com/notifications/5fff0ab3f28427000a77941e

Acceptance Test Output

$ make testacc TESTS=TestAccXXX

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@github-actions
Copy link
Copy Markdown

This PR has become stale as it has been open 30 days with no activity.
Stale PRs will be closed after 5 days if no action is taken. If you
think this PR should not be closed, remove the stale label.

@github-actions github-actions bot added the stale label Mar 23, 2021
@kpurdon
Copy link
Copy Markdown
Contributor Author

kpurdon commented Mar 23, 2021

@alexkappa here is the stale bot I mentioned. This is active and just waiting on the Go PR and review.

@kpurdon
Copy link
Copy Markdown
Contributor Author

kpurdon commented Mar 24, 2021

@yvovandoorn once go-auth0/auth0#187 is part of a release I can update and test this. Let me know, and I'll jump on it ASAP.

@yvovandoorn
Copy link
Copy Markdown
Contributor

@yvovandoorn
Copy link
Copy Markdown
Contributor

hey @kpurdon I updated go.mod and go.sum in master to require 5.13.0, as 5.12.0 somehow dropped SetUserAttributes for the OIDC connection.

@kpurdon
Copy link
Copy Markdown
Contributor Author

kpurdon commented Mar 24, 2021

@yvovandoorn updated, tests passing for me locally

kpurdon@syndio: ~/.../kpurdon/terraform-provider-auth0 make testacc TESTS=TestAccPrompt
==> Checking that code complies with gofmt requirements...
?   	github.com/alexkappa/terraform-provider-auth0	[no test files]
=== RUN   TestAccPrompt
--- PASS: TestAccPrompt (4.22s)
PASS
coverage: 6.2% of statements
ok  	github.com/alexkappa/terraform-provider-auth0/auth0	4.873s	coverage: 6.2% of statements
?   	github.com/alexkappa/terraform-provider-auth0/auth0/internal/debug	[no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok  	github.com/alexkappa/terraform-provider-auth0/auth0/internal/random	0.450s	coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok  	github.com/alexkappa/terraform-provider-auth0/auth0/internal/validation	0.498s	coverage: 0.0% of statements [no tests to run]
?   	github.com/alexkappa/terraform-provider-auth0/version	[no test files]

@yvovandoorn
Copy link
Copy Markdown
Contributor

💥 🚀

Thanks for the addition @kpurdon. Merging now.

@yvovandoorn yvovandoorn merged commit 767e65d into alexkappa:master Mar 24, 2021
@kpurdon kpurdon deleted the kpurdon/add-prompt-identifier-first branch March 24, 2021 21:07
@franklouwers
Copy link
Copy Markdown

Just FYI for people arriving here: we were using the previous released version (0.19.0) of this provider which didn't support this setting. We needed the setting (for SSO integrations) so we manually changed the setting in auth0. A colleague then (accidentally) upgraded to 0.20.0, which seem to have flipped our settings back to the default (the equiv of identifier_first false)!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants