Skip to content
This repository was archived by the owner on Mar 8, 2022. It is now read-only.

Feature/add signing cert option to samlp addon on auth0 client#426

Merged
sergiught merged 4 commits intoalexkappa:masterfrom
ca-simone-chiorazzo:feature/add-signing-cert-option-to-samlp-addon-on-auth0-client
Jan 24, 2022
Merged

Feature/add signing cert option to samlp addon on auth0 client#426
sergiught merged 4 commits intoalexkappa:masterfrom
ca-simone-chiorazzo:feature/add-signing-cert-option-to-samlp-addon-on-auth0-client

Conversation

@ca-simone-chiorazzo
Copy link
Copy Markdown
Contributor

Proposed Changes

  • Add signingCert option to the samlp addon of the Auth0 client

Acceptance Test Output

$ make testacc TESTS=TestAccXXX

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@ca-simone-chiorazzo
Copy link
Copy Markdown
Contributor Author

@alexkappa Any chance to have this PR reviewed and merged?

@ca-simone-chiorazzo
Copy link
Copy Markdown
Contributor Author

@alexkappa Could you please take a look at this PR? It would be great to have it merged in the main repository

@ca-simone-chiorazzo
Copy link
Copy Markdown
Contributor Author

@sergiughf Maybe you have time to take a look also at this PR? 😄 It's open from August and it would be great have it merged in the main repository.

Let me know what are your thoughts on this!

Thanks

@sergiught
Copy link
Copy Markdown
Collaborator

Ciao @ca-simone-chiorazzo, thanks for the contribution! I'm gonna try to take a look at this tomorrow. 🙏🏻

@sergiught
Copy link
Copy Markdown
Collaborator

Hey @ca-simone-chiorazzo, thanks a lot for the contribution! We tested it and it seems to work great. I just left a few small notes that would be great to fix before we can merge. Let me know if you have any questions!

@sergiught sergiught force-pushed the feature/add-signing-cert-option-to-samlp-addon-on-auth0-client branch from adf41ff to 742bed0 Compare January 24, 2022 09:28
@sergiught
Copy link
Copy Markdown
Collaborator

Hey @ca-simone-chiorazzo, I had some time and managed to rebase your PR and address the tiny comments above.

Thanks again for the contribution! 🥳

@sergiught sergiught merged commit 0e93971 into alexkappa:master Jan 24, 2022
@ca-simone-chiorazzo
Copy link
Copy Markdown
Contributor Author

Hi @sergiughf, thank you for your effort!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants