Skip to content
This repository was archived by the owner on Mar 8, 2022. It is now read-only.

Implements the native_social_login stanza on the Client API.#453

Merged
sergiught merged 4 commits intoalexkappa:masterfrom
cthos:add-native-social
Jan 17, 2022
Merged

Implements the native_social_login stanza on the Client API.#453
sergiught merged 4 commits intoalexkappa:masterfrom
cthos:add-native-social

Conversation

@cthos
Copy link
Copy Markdown
Contributor

@cthos cthos commented Oct 1, 2021

This setting is used to toggle "Enable native Apple/Facebook" login on
and off.

Proposed Changes

  • Adds support for the native_social_login stanza in the Client API.
  • Adds documentation
  • Updates Mobile Tests

Fixes #0000

Acceptance Test Output

Ran the whole suite, but only included the relevant part:

$ make testacc TESTS=TestAccClient          
==> Checking that code complies with gofmt requirements...
?       github.com/alexkappa/terraform-provider-auth0   [no test files]
=== RUN   TestAccClientGrant
--- PASS: TestAccClientGrant (22.16s)
=== RUN   TestAccClient
--- PASS: TestAccClient (2.16s)
=== RUN   TestAccClientZeroValueCheck
--- PASS: TestAccClientZeroValueCheck (11.15s)
=== RUN   TestAccClientRotateSecret
--- PASS: TestAccClientRotateSecret (3.07s)
=== RUN   TestAccClientInitiateLoginUri
--- PASS: TestAccClientInitiateLoginUri (0.02s)
=== RUN   TestAccClientJwtScopes
--- PASS: TestAccClientJwtScopes (3.59s)
=== RUN   TestAccClientMobile
--- PASS: TestAccClientMobile (10.77s)
=== RUN   TestAccClientMobileValidationError
--- PASS: TestAccClientMobileValidationError (0.02s)
PASS
coverage: 21.7% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0     53.407s coverage: 21.7% of statements
?       github.com/alexkappa/terraform-provider-auth0/auth0/internal/debug      [no test files]

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Copy link
Copy Markdown

@kiranms-newpage kiranms-newpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ca-simone-chiorazzo
Copy link
Copy Markdown
Contributor

ca-simone-chiorazzo commented Jan 5, 2022

@kiranms-newpage @alexkappa Any chance to get this PR merged? It would solve also the issue that I've opened yesterday #488

@kiranms-newpage
Copy link
Copy Markdown

@ca-simone-chiorazzo sorry, I don't have permission to merge. We also needed this functionality along with few other. But none of them are being merged :-(

@ca-simone-chiorazzo
Copy link
Copy Markdown
Contributor

@alexkappa Could you please merge this PR?

@lorthirk
Copy link
Copy Markdown

+1!

@krissetto
Copy link
Copy Markdown

This would be needed on my side too, I hope we can get this merged asap!

@ca-simone-chiorazzo
Copy link
Copy Markdown
Contributor

@sergiughf It is something that you can handle on behalf of @alexkappa?

@sergiught
Copy link
Copy Markdown
Collaborator

Hey folks, I'll take a look ASAP.

@sergiught sergiught merged commit 8ca0c0b into alexkappa:master Jan 17, 2022
@sergiught
Copy link
Copy Markdown
Collaborator

sergiught commented Jan 17, 2022

I added a few improvements in a965541 and released this under https://github.com/alexkappa/terraform-provider-auth0/releases/tag/v0.25.1
! 🥳

Thank you so much for the contribution @cthos! It was a really great PR to review!

And really appreciate everyone's patience, @ca-simone-chiorazzo, @krissetto, @lorthirk, @kiranms-newpage.

@kiranms-newpage
Copy link
Copy Markdown

Thanks a lot @sergiughf .

@ca-simone-chiorazzo
Copy link
Copy Markdown
Contributor

Thanks, @sergiughf !

@cthos
Copy link
Copy Markdown
Contributor Author

cthos commented Jan 18, 2022

Thank you so much for the contribution @cthos! It was a really great PR to review!

Aw, thanks! And thanks to you as well @sergiughf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants