This repository was archived by the owner on Mar 8, 2022. It is now read-only.
Support entity_id in samlp connection#468
Merged
alexkappa merged 1 commit intoalexkappa:masterfrom Dec 13, 2021
Merged
Conversation
alexkappa
approved these changes
Nov 10, 2021
Owner
alexkappa
left a comment
There was a problem hiding this comment.
Code looks good @hoppalotta. Will need to run the tests and if all is well we can merge it
Contributor
Author
|
Hi @alexkappa, seeking an update to this PR status if you have the time. Thanks! |
Owner
|
@hoppalotta all tests pass so I'll be merging this in. Thanks for the contribution and your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Acceptance Test Output
Community Note