Skip to content
This repository was archived by the owner on Mar 8, 2022. It is now read-only.

Support entity_id in samlp connection#468

Merged
alexkappa merged 1 commit intoalexkappa:masterfrom
hoppalotta:support-custom-entityid
Dec 13, 2021
Merged

Support entity_id in samlp connection#468
alexkappa merged 1 commit intoalexkappa:masterfrom
hoppalotta:support-custom-entityid

Conversation

@hoppalotta
Copy link
Copy Markdown
Contributor

Proposed Changes

  • Extend existing auth0_connection resource to support custom Entity ID in samlp connection options

Acceptance Test Output

$ make testacc TESTS=TestAccXXX
==> Checking that code complies with gofmt requirements...
?       github.com/alexkappa/terraform-provider-auth0   [no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_debugDefaults
--- PASS: TestProvider_debugDefaults (0.00s)
=== RUN   TestAccBranding
--- PASS: TestAccBranding (5.07s)
=== RUN   TestAccClientGrant
--- PASS: TestAccClientGrant (26.83s)
=== RUN   TestAccClient
--- PASS: TestAccClient (2.73s)
=== RUN   TestAccClientZeroValueCheck
--- PASS: TestAccClientZeroValueCheck (5.70s)
=== RUN   TestAccClientRotateSecret
--- PASS: TestAccClientRotateSecret (3.92s)
=== RUN   TestAccClientInitiateLoginUri
--- PASS: TestAccClientInitiateLoginUri (0.03s)
=== RUN   TestAccClientJwtScopes
--- PASS: TestAccClientJwtScopes (3.42s)
=== RUN   TestAccClientMobile
--- PASS: TestAccClientMobile (3.67s)
=== RUN   TestAccClientMobileValidationError
--- PASS: TestAccClientMobileValidationError (0.01s)
=== RUN   TestAccConnection
--- PASS: TestAccConnection (9.20s)
=== RUN   TestAccConnectionAD
--- PASS: TestAccConnectionAD (2.11s)
=== RUN   TestAccConnectionAzureAD
--- PASS: TestAccConnectionAzureAD (3.50s)
=== RUN   TestAccConnectionOIDC
--- PASS: TestAccConnectionOIDC (4.03s)
=== RUN   TestAccConnectionOAuth2
--- PASS: TestAccConnectionOAuth2 (3.75s)
=== RUN   TestAccConnectionWithEnbledClients
--- PASS: TestAccConnectionWithEnbledClients (14.90s)
=== RUN   TestAccConnectionSMS
--- PASS: TestAccConnectionSMS (1.88s)
=== RUN   TestAccConnectionEmail
--- PASS: TestAccConnectionEmail (3.60s)
=== RUN   TestAccConnectionSalesforce
--- PASS: TestAccConnectionSalesforce (1.73s)
=== RUN   TestAccConnectionGoogleOAuth2
--- PASS: TestAccConnectionGoogleOAuth2 (1.81s)
=== RUN   TestAccConnectionFacebook
--- PASS: TestAccConnectionFacebook (9.92s)
=== RUN   TestAccConnectionApple
--- PASS: TestAccConnectionApple (3.77s)
=== RUN   TestAccConnectionLinkedin
--- PASS: TestAccConnectionLinkedin (3.36s)
=== RUN   TestAccConnectionGitHub
--- PASS: TestAccConnectionGitHub (2.52s)
=== RUN   TestAccConnectionWindowslive
--- PASS: TestAccConnectionWindowslive (4.24s)
=== RUN   TestAccConnectionConfiguration
--- PASS: TestAccConnectionConfiguration (3.60s)
=== RUN   TestConnectionInstanceStateUpgradeV0
=== RUN   TestConnectionInstanceStateUpgradeV0/Empty
=== RUN   TestConnectionInstanceStateUpgradeV0/Zero
=== RUN   TestConnectionInstanceStateUpgradeV0/NonZero
=== RUN   TestConnectionInstanceStateUpgradeV0/Invalid
--- PASS: TestConnectionInstanceStateUpgradeV0 (0.00s)
    --- PASS: TestConnectionInstanceStateUpgradeV0/Empty (0.00s)
    --- PASS: TestConnectionInstanceStateUpgradeV0/Zero (0.00s)
    --- PASS: TestConnectionInstanceStateUpgradeV0/NonZero (0.00s)
    --- PASS: TestConnectionInstanceStateUpgradeV0/Invalid (0.00s)
=== RUN   TestConnectionInstanceStateUpgradeV1
=== RUN   TestConnectionInstanceStateUpgradeV1/Only_Min
=== RUN   TestConnectionInstanceStateUpgradeV1/Min_and_Max
--- PASS: TestConnectionInstanceStateUpgradeV1 (0.00s)
    --- PASS: TestConnectionInstanceStateUpgradeV1/Only_Min (0.00s)
    --- PASS: TestConnectionInstanceStateUpgradeV1/Min_and_Max (0.00s)
=== RUN   TestAccConnectionSAML
--- PASS: TestAccConnectionSAML (4.12s)
=== RUN   TestAccCustomDomain
--- PASS: TestAccCustomDomain (11.52s)
=== RUN   TestAccEmailTemplate
--- PASS: TestAccEmailTemplate (2.72s)
=== RUN   TestAccEmail
--- PASS: TestAccEmail (5.44s)
=== RUN   TestAccGlobalClient
--- PASS: TestAccGlobalClient (11.27s)
=== RUN   TestAccGuardian
--- PASS: TestAccGuardian (57.34s)
=== RUN   TestAccHook
--- PASS: TestAccHook (2.16s)
=== RUN   TestAccHookSecrets
--- PASS: TestAccHookSecrets (13.00s)
=== RUN   TestHookNameRegexp
--- PASS: TestHookNameRegexp (0.00s)
=== RUN   TestAccLogStreamHTTP
--- PASS: TestAccLogStreamHTTP (4.79s)
=== RUN   TestAccLogStreamEventBridge
--- PASS: TestAccLogStreamEventBridge (6.93s)
=== RUN   TestAccLogStreamEventGrid
    resource_auth0_log_stream_test.go:201: this test requires an active subscription
--- SKIP: TestAccLogStreamEventGrid (0.00s)
=== RUN   TestAccLogStreamDatadog
--- PASS: TestAccLogStreamDatadog (9.68s)
=== RUN   TestAccLogStreamSplunk
--- PASS: TestAccLogStreamSplunk (4.41s)
=== RUN   TestAccLogStreamSumo
--- PASS: TestAccLogStreamSumo (3.19s)
=== RUN   TestAccOrganization
--- PASS: TestAccOrganization (9.94s)
=== RUN   TestAccPrompt
--- PASS: TestAccPrompt (2.71s)
=== RUN   TestAccResourceServer
--- PASS: TestAccResourceServer (3.13s)
=== RUN   TestAccRole
--- PASS: TestAccRole (16.80s)
=== RUN   TestAccRolePermissions
--- PASS: TestAccRolePermissions (5.53s)
=== RUN   TestAccRuleConfig
--- PASS: TestAccRuleConfig (11.07s)
=== RUN   TestAccRule
--- PASS: TestAccRule (2.16s)
=== RUN   TestRuleNameRegexp
--- PASS: TestRuleNameRegexp (0.00s)
=== RUN   TestAccTenant
--- PASS: TestAccTenant (3.41s)
=== RUN   TestAccUserMissingRequiredParams
--- PASS: TestAccUserMissingRequiredParams (0.02s)
=== RUN   TestAccUser
--- PASS: TestAccUser (21.64s)
=== RUN   TestAccUserIssue218
--- PASS: TestAccUserIssue218 (9.10s)
=== RUN   TestAccUserChangeUsername
--- PASS: TestAccUserChangeUsername (5.35s)
=== RUN   TestMapData
=== RUN   TestMapData/GetOk
=== RUN   TestMapData/GetOkExists
--- PASS: TestMapData (0.00s)
    --- PASS: TestMapData/GetOk (0.00s)
    --- PASS: TestMapData/GetOkExists (0.00s)
=== RUN   TestJSON
--- PASS: TestJSON (0.00s)
=== RUN   TestIsNil
--- PASS: TestIsNil (0.00s)
PASS
coverage: 79.7% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0     352.786s        coverage: 79.7% of statements
?       github.com/alexkappa/terraform-provider-auth0/auth0/internal/debug      [no test files]
=== RUN   TestStringKey
=== RUN   TestStringKey/Bar
=== RUN   TestStringKey/Foo
--- PASS: TestStringKey (0.00s)
    --- PASS: TestStringKey/Bar (0.00s)
    --- PASS: TestStringKey/Foo (0.00s)
PASS
coverage: 71.4% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/hash       0.009s  coverage: 71.4% of statements
=== RUN   TestString
--- PASS: TestString (0.00s)
=== RUN   TestTemplate
--- PASS: TestTemplate (0.00s)
PASS
coverage: 75.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/random     0.012s  coverage: 75.0% of statements
=== RUN   TestIsURLWithNoFragment
--- PASS: TestIsURLWithNoFragment (0.00s)
PASS
coverage: 52.9% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/validation 0.004s  coverage: 52.9% of statements
?       github.com/alexkappa/terraform-provider-auth0/version   [no test files]
...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Copy link
Copy Markdown
Owner

@alexkappa alexkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good @hoppalotta. Will need to run the tests and if all is well we can merge it

@hoppalotta
Copy link
Copy Markdown
Contributor Author

Hi @alexkappa, seeking an update to this PR status if you have the time. Thanks!

@alexkappa alexkappa merged commit 86bb85a into alexkappa:master Dec 13, 2021
@alexkappa
Copy link
Copy Markdown
Owner

@hoppalotta all tests pass so I'll be merging this in. Thanks for the contribution and your patience!

@hoppalotta hoppalotta deleted the support-custom-entityid branch December 23, 2021 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants