Skip to content

fix(results): unescaped lvl0#1001

Merged
shortcuts merged 4 commits into
nextfrom
fix/results
Apr 7, 2021
Merged

fix(results): unescaped lvl0#1001
shortcuts merged 4 commits into
nextfrom
fix/results

Conversation

@shortcuts

Copy link
Copy Markdown
Member

Summary

In some cases, the hits returned by the engine can contain escaped characters. We now retrieve the lvl0 from the _highlightResults (which are always unescaped) and remove the highlighting tags.

before after
Screenshot 2021-03-31 at 16 55 12 Screenshot 2021-03-31 at 16 59 27

Comment thread packages/docsearch-react/src/utils/unescape.ts Outdated
@codesandbox-ci

codesandbox-ci Bot commented Mar 31, 2021

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5ea358b:

Sandbox Source
Vanilla Configuration

Comment thread packages/docsearch-react/src/ResultsScreen.tsx Outdated
@shortcuts shortcuts merged commit 117228b into next Apr 7, 2021
@shortcuts shortcuts deleted the fix/results branch April 7, 2021 09:04
@ericxjohnston

Copy link
Copy Markdown

@shortcuts Thanks Clement for merging these changes! Do you know when the next alpha version will be released?

@shortcuts

Copy link
Copy Markdown
Member Author

Hi @ericxjohnston, the version v3.0.0-alpha.35 is now released.

@ericxjohnston

Copy link
Copy Markdown

@shortcuts Thanks Clement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants