Skip to content

fix: eliminate keyboard shortcuts UI flash #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoischalifour merged 5 commits into from
Jul 21, 2021
Merged

fix: eliminate keyboard shortcuts UI flash #1021

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4697e5
fix(css): set width for .DocSearch-Button
chenxsan Jul 16, 2021
330d06e
Apply suggestions from code review
chenxsan Jul 16, 2021
16b2ef9
revert css changes
chenxsan Jul 21, 2021
d2d87ce
remove setKey
chenxsan Jul 21, 2021
55b9e7a
use useMemo
chenxsan Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/docsearch-react/src/DocSearchButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useEffect, useState } from 'react';
import React, { useState } from 'react';

import { ControlKeyIcon } from './icons/ControlKeyIcon';
import { SearchIcon } from './icons/SearchIcon';
Expand All @@ -25,15 +25,14 @@ export const DocSearchButton = React.forwardRef<
>(({ translations = {}, ...props }, ref) => {
const { buttonText = 'Search', buttonAriaLabel = 'Search' } = translations;

const [key, setKey] = useState<
const [key] = useState<
Comment thread
chenxsan marked this conversation as resolved.
Outdated
typeof ACTION_KEY_APPLE | typeof ACTION_KEY_DEFAULT | null
>(null);

useEffect(() => {
>(() => {
if (typeof navigator !== 'undefined') {
setKey(isAppleDevice() ? ACTION_KEY_APPLE : ACTION_KEY_DEFAULT);
return isAppleDevice() ? ACTION_KEY_APPLE : ACTION_KEY_DEFAULT;
}
}, []);
return null;
});

return (
<button
Expand Down
⚡