Skip to content

fix(v3): pass initialQuery#1051

Merged
shortcuts merged 1 commit into
nextfrom
fix/initial-query
Sep 30, 2021
Merged

fix(v3): pass initialQuery#1051
shortcuts merged 1 commit into
nextfrom
fix/initial-query

Conversation

@shortcuts

@shortcuts shortcuts commented Sep 30, 2021

Copy link
Copy Markdown
Member

Summary

initialQuery wasn't passed from the props to the state, which made it unusable.

see sandbox

Result

Search input is initialized with initialQuery

see sandbox

Related issue: #1050

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e15dc80:

Sandbox Source
Vanilla Configuration
festive-sara-7o8nf PR

@algolia algolia deleted a comment from netlify Bot Sep 30, 2021

@bodinsamuel bodinsamuel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I see no unit test in this repo, we might want to make the stack a bit more reliable at some point.

@shortcuts

Copy link
Copy Markdown
Member Author

I see no unit test in this repo, we might want to make the stack a bit more reliable at some point.

Since we mostly rely on Autocomplete, it's tested on that side, but we indeed should at least validate props.

I'll add a task to the backlog

@shortcuts shortcuts merged commit 6e194c7 into next Sep 30, 2021
@shortcuts shortcuts deleted the fix/initial-query branch September 30, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants