feat(styles): set medium breakpoint to standarized value#1446
Merged
Conversation
✅ Deploy Preview for docsearch canceled.
|
tnir
force-pushed
the
tnir-css-de-facto-breakpoints
branch
from
3fbd52d to
9825604
Compare
768px has been much more common for many years (since 2010), and other major CSS frameworks have used 768px as the breakpoint for years. Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir
force-pushed
the
tnir-css-de-facto-breakpoints
branch
from
9825604 to
b36b061
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d2b83b:
|
shortcuts
reviewed
Jul 21, 2022
shortcuts
left a comment
shortcuts
left a comment
Member
There was a problem hiding this comment.
Thanks! It make sense indeed since it's standarized.
Could you group all of the changes in this PR please? It would make more sense in the changelog and if we need to point this change later.
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir
changed the title
Contributor
Author
|
@shortcuts Thank you. Both commits are now in this PR. Could you change the commit message with the below (or whatever you like) when you squash-merge? |
shortcuts
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
768px has been much more common for many years (since 2010), and other major CSS frameworks have used 768px as the breakpoint for years.
Closes #1444
Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com