Skip to content

refactor: improve readability of _variables.css#2359

Merged
millotp merged 6 commits intoalgolia:mainfrom
lumirlumir:patch-1
Nov 16, 2024
Merged

refactor: improve readability of _variables.css#2359
millotp merged 6 commits intoalgolia:mainfrom
lumirlumir:patch-1

Conversation

@lumirlumir
Copy link
Copy Markdown
Contributor

@lumirlumir lumirlumir commented Nov 16, 2024

Hello, I've improved the readability of _variables.css.

The code had a different style of formatting compared to the rest, which I believe reduced readability for others.

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 16, 2024

Deploy Preview for docsearch ready!

Name Link
🔨 Latest commit bba597c
🔍 Latest deploy log https://app.netlify.com/sites/docsearch/deploys/6739132b3ca6990008c015af
😎 Deploy Preview https://deploy-preview-2359--docsearch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lumirlumir lumirlumir marked this pull request as ready for review November 16, 2024 11:15
Copy link
Copy Markdown
Contributor

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, we actually have a linter for css, we never run it because it shows too many errors, I took the liberty to run it on your PR, thanks for the contribution !

@millotp millotp enabled auto-merge (squash) November 16, 2024 21:50
@millotp millotp merged commit f3dc646 into algolia:main Nov 16, 2024
@lumirlumir lumirlumir deleted the patch-1 branch November 17, 2024 09:39
@XhmikosR
Copy link
Copy Markdown

@millotp please check out #2414. I'd revert the @media changes because they break older Sass clients and it's a breaking change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants