Refactor data source hierarchy: spilt into readable and writable data source#124
Merged
sczyh30 merged 4 commits intoalibaba:masterfrom Sep 4, 2018
sczyh30:refactor/data-source
Merged
Refactor data source hierarchy: spilt into readable and writable data source#124sczyh30 merged 4 commits intoalibaba:masterfrom sczyh30:refactor/data-source
sczyh30 merged 4 commits intoalibaba:masterfrom
sczyh30:refactor/data-source
Conversation
- Spilt DataSource into two types: ReadableDataSource and WritableDataSource - The AbstractDataSource now is read-only - Refactor the file data source for writable implementation - Rename: ConfigParser -> Converter (represents both encoder `T -> S` and decoder `S -> T`) - Some other refinement Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- Refine code about writable datasource Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
============================================
+ Coverage 45.75% 45.77% +0.02%
Complexity 555 555
============================================
Files 114 114
Lines 3814 3814
Branches 531 531
============================================
+ Hits 1745 1746 +1
+ Misses 1857 1856 -1
Partials 212 212
Continue to review full report at Codecov.
|
- Add `close` method in WritableDataSource (to extend AutoCloseable in JDK 1.7 later) - Separate the writable file data source from original class - Add a sample to show how to register data sources via Sentinel init mechanism - Separate a writable data source registry from original handler to make it clear Signed-off-by: Eric Zhao <sczyh16@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Spilt data source into readable and writable data source. See #94 for details.
Does this pull request fix one issue?
Closes #94
Describe how you did it
DataSourceinto two types:ReadableDataSourceandWritableDataSourceAbstractDataSourcenow is read-only.ReadableDataSourceandWritableDataSource)ConfigParser->Converter(represents both encoderT -> Sand decoderS -> T)Describe how to verify it
See demo.