Support prioritized entry in ProcessorSlot interface#255
Merged
Conversation
- Add `entryWithPriority` in SphU Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
============================================
+ Coverage 51.78% 52.42% +0.63%
- Complexity 894 903 +9
============================================
Files 150 150
Lines 5030 5036 +6
Branches 723 723
============================================
+ Hits 2605 2640 +35
+ Misses 2110 2077 -33
- Partials 315 319 +4
Continue to review full report at Codecov.
|
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
4 tasks
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
- Refactor the slot interface to support prioritized entry - Add `entryWithPriority` in SphU Signed-off-by: Eric Zhao <sczyh16@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Support prioritized entry in ProcessorSlot interface so that each slot can handle requests with priority.
Does this pull request fix one issue?
Related to #207
Describe how you did it
ProcessorSlotinterface (add a parameterprioritizedin entry-related methods)entryWithPrioritymethods inSphU(separate fromentrymethod so that it won't be confused with previousentrywith args)Describe how to verify it
This is only a change for interface. Run all test cases to ensure nothing broken.
Special notes for reviews
NONE