add some unit test for sentinel-transport-netty-http module#321
Merged
sczyh30 merged 2 commits intoalibaba:masterfrom Dec 26, 2018
Merged
add some unit test for sentinel-transport-netty-http module#321sczyh30 merged 2 commits intoalibaba:masterfrom
sczyh30 merged 2 commits intoalibaba:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
============================================
- Coverage 38.71% 38.28% -0.44%
+ Complexity 936 930 -6
============================================
Files 218 218
Lines 6912 6912
Branches 938 938
============================================
- Hits 2676 2646 -30
- Misses 3897 3932 +35
+ Partials 339 334 -5
Continue to review full report at Codecov.
|
Member
|
Great! Thanks for contributing! |
canglang1973
pushed a commit
to canglang1973/Sentinel
that referenced
this pull request
Dec 26, 2018
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
The
sentinel-transport-netty-httpmodule doesn't have test package, add some unit test.Does this pull request fix one issue?
NONE
Describe how you did it
Import
junitandmockito-coredependency, and use Netty'sEmbeddedChannelfor test ChannelHandler.Describe how to verify it
run mvn test
Special notes for reviews
one test case
testGetRuleCommandFlowSomeRules, since I haven't found a good way yet,comment the@Testannotation and marked it with theFIXMEcomment, for improving it in the future.