upgrade nacos-client version and construct NacosDataSource by Properties#348
Merged
sczyh30 merged 2 commits intoalibaba:masterfrom Dec 27, 2018
Merged
upgrade nacos-client version and construct NacosDataSource by Properties#348sczyh30 merged 2 commits intoalibaba:masterfrom
sczyh30 merged 2 commits intoalibaba:masterfrom
Conversation
…structor for NacosDataSource to support namespace, endpoint, ak, sk and so on
|
|
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
============================================
+ Coverage 38.21% 38.22% +0.01%
Complexity 936 936
============================================
Files 218 218
Lines 6966 6966
Branches 948 948
============================================
+ Hits 2662 2663 +1
+ Misses 3966 3965 -1
Partials 338 338
Continue to review full report at Codecov.
|
Member
|
Hi, could you please sign the CLA? |
Contributor
Author
|
Yes, done! |
sczyh30
reviewed
Dec 27, 2018
...atasource-nacos/src/main/java/com/alibaba/csp/sentinel/datasource/nacos/NacosDataSource.java
Show resolved
Hide resolved
Member
|
Thanks for your contribution! |
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
…ies (alibaba#348) * Polish alibaba#272: upgrade nacos-client version and create a new constructor for NacosDataSource to support namespace, endpoint, ak, sk and so on * check properties in NacosDataSource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this pull request fix one issue?
Resolves #272
Describe how you did it
constructor
ConfigServicebyNacosFactory#createConfigService(Properties properties)and add a new constructor forNacosDataSource.Describe how to verify it
NacosDataSourceDemoruns well.