Add a CommandCenterProvider to resolve CommandCenter API and cache the instance#409
Merged
sczyh30 merged 1 commit intoalibaba:masterfrom Mar 4, 2019
Merged
Conversation
…e the CommandCenter instance
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=========================================
Coverage 37.73% 37.73%
Complexity 982 982
=========================================
Files 235 235
Lines 7407 7407
Branches 1014 1014
=========================================
Hits 2795 2795
Misses 4253 4253
Partials 359 359Continue to review full report at Codecov.
|
Member
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Cache the CommandCenter instance so that we can invoke any methods with it when needed.
Does this pull request fix one issue?
Fixes #345
Describe how you did it
Add a Class
CommandCenterProviderwhich hold a CommandCenter instance, resolve the instanceby SPI and add a
getCommandCenter()method to get the instance.Describe how to verify it
Run sentinel-dashboard and make a breakpoint to test if CommandCenter loaded as expected.
Special notes for reviews
I found a useful method
SpiLoader.loadFirstInstance(CommandCenter.class);to get the API,which only get the first API instance,
but previous
CommandCenterInitFuncchecked "Only single command center can be started",I think it's okay not to check the unique, since load first API can worked and user can also
check in sentinel-record.log.