Allow negative paramIndex in ParamFlowRule#549
Merged
Conversation
Signed-off-by: Carpenter Lee <hooleeucas@163.com>
sczyh30
reviewed
Mar 6, 2019
...-control/src/main/java/com/alibaba/csp/sentinel/slots/block/flow/param/ParamFlowChecker.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Carpenter Lee <hooleeucas@163.com>
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
============================================
+ Coverage 37.51% 38.02% +0.51%
- Complexity 1102 1112 +10
============================================
Files 259 259
Lines 8171 8177 +6
Branches 1113 1115 +2
============================================
+ Hits 3065 3109 +44
+ Misses 4715 4664 -51
- Partials 391 404 +13
Continue to review full report at Codecov.
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carpenter Lee hooleeucas@163.com
Describe what this PR does / why we need it
Negative paramIndex in
ParamFlowRuleis useful in some case, eg when we want to count params from the opposite direction. But Sentinel does not allow negative paramIndex inParamFlowRulenow.Does this pull request fix one issue?
NONE
Describe how you did it
Change
ParamFlowRuleUtilandParamFlowCheckerto allow negative paramIndex in ParamFlowRuleDescribe how to verify it
Run unit test cases
Special notes for reviews