Improve the field name flowRulesKey in ApolloDataSource#593
Merged
sczyh30 merged 1 commit intoalibaba:masterfrom Mar 20, 2019
lawrencewu:enhencement/typo
Merged
Improve the field name flowRulesKey in ApolloDataSource#593sczyh30 merged 1 commit intoalibaba:masterfrom lawrencewu:enhencement/typo
sczyh30 merged 1 commit intoalibaba:masterfrom
lawrencewu:enhencement/typo
Conversation
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
===========================================
- Coverage 39.86% 39.8% -0.06%
+ Complexity 1244 1243 -1
===========================================
Files 275 275
Lines 8702 8702
Branches 1163 1163
===========================================
- Hits 3469 3464 -5
- Misses 4785 4793 +8
+ Partials 448 445 -3
Continue to review full report at Codecov.
|
Member
|
Hi, thanks for contributing. Could you please sign the CLA here? And please make sure the email of your commits match your GitHub email. 感谢贡献,请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配并 确认一下 CLA。 |
Member
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR is used to correct the field name flowRulesKey and defaultFlowRuleValue in ApolloDataSource to enhence readable.
Does this pull request fix one issue?
Fixed #590
Describe how you did it
Describe how to verify it
Special notes for reviews