Add getCpuUsageThreshold() method in SystemRuleManager#770
Merged
sczyh30 merged 6 commits intoalibaba:masterfrom May 21, 2019
Merged
Add getCpuUsageThreshold() method in SystemRuleManager#770sczyh30 merged 6 commits intoalibaba:masterfrom
sczyh30 merged 6 commits intoalibaba:masterfrom
Conversation
Receive the latest request
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
============================================
- Coverage 41% 40.92% -0.08%
+ Complexity 1334 1333 -1
============================================
Files 301 301
Lines 8629 8630 +1
Branches 1159 1159
============================================
- Hits 3538 3532 -6
- Misses 4665 4671 +6
- Partials 426 427 +1
Continue to review full report at Codecov.
|
sczyh30
requested changes
May 20, 2019
sentinel-core/src/main/java/com/alibaba/csp/sentinel/slots/system/SystemRuleManager.java
Outdated
Show resolved
Hide resolved
Member
|
And I think if you're going to retrieve the current CPU usage and load of your system, you may get them via: SystemRuleManager.getCurrentCpuUsage();
SystemRuleManager.getCurrentSystemAvgLoad()The |
sczyh30
reviewed
May 21, 2019
sentinel-core/src/main/java/com/alibaba/csp/sentinel/slots/system/SystemRuleManager.java
Outdated
Show resolved
Hide resolved
Member
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Open getHighest CpuUsage to send custom alarm when system current limit occurs。
Does this pull request fix one issue?
Fixes #769
Describe how you did it
Adding getHighestCpuUsage Method
Describe how to verify it
Access via SystemRuleManager. getHighestCpuUsage
Special notes for reviews