feat: add function to attach Playwright Trace#1274
Merged
Conversation
github-actions
Bot
added
theme:api
epszaw
requested changes
Mar 18, 2025
| await test.info().attach(name, { path, contentType: options.contentType }); | ||
| } | ||
|
|
||
| async attachTrace(name: string, content: Buffer) { |
Member
There was a problem hiding this comment.
Keep the function from commons only
epszaw
approved these changes
Mar 18, 2025
epszaw
requested changes
Mar 19, 2025
| } else { | ||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion | ||
| const contentType = | ||
| attachment.name === "trace" ? "application/vnd.allure.playwright-trace" : attachment.contentType; |
Member
There was a problem hiding this comment.
Check the attachment content type too to be sure because we can have trace.jpg, trace.js etc.:
attachment.name === "trace" && attachment.contentType === "application/zip" ? ...
epszaw
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Add special contentType
application/vnd.allure.playwright-tracefor Playwright Trace archives.Checklist