Skip to content

updatePassedSnapshot updates all snapshot regardless of jest --updatesnapshot value #325

@JeremyJonas

Description

@JeremyJonas

const shouldUpdate = ({ pass, updateSnapshot, updatePassedSnapshot }) => (
(!pass && updateSnapshot) || (pass && updatePassedSnapshot)
);

Expected Result

I expected updatePassedSnapshot to only update "passed" snapshots when jest --updatesnapshot flag is present.

Current Result

When updatePassedSnapshot is true, it will always update all snapshot, regardless of being enabled in jest.

Proposal

Only consider updatePassedSnapshot if updateSnapshot is also true, which I am assuming it aligned to jest flag.

 const shouldUpdate = ({ pass, updateSnapshot, updatePassedSnapshot }) => updateSnapshot && (!pass || (pass && updatePassedSnapshot)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions