Skip to content

fix: Changes to consider only updatePassedSnapshot if updateSnapshot is also true #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
10xLaCroixDrinker merged 9 commits into from
Jul 25, 2023
Merged

fix: Changes to consider only updatePassedSnapshot if updateSnapshot is also true #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2c724e0
chore(deps): bump qs from 6.5.2 to 6.5.3 (#320)
goverdhan07 Jul 23, 2023
83d2142
chore(deps): make jest optional peerDependency (#322)
goverdhan07 Jul 23, 2023
da99760
chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (#324)
goverdhan07 Jul 23, 2023
e98d14e
fix: updatePassedSnapshot to only update passed snapshots when jest -…
goverdhan07 Jul 23, 2023
b933927
fix: fixed indentations
goverdhan07 Jul 23, 2023
71021bb
fix: added unit test case
goverdhan07 Jul 23, 2023
73990b7
Merge branch 'main' into main
goverdhan07 Jul 23, 2023
6cf2343
removed package.json file
goverdhan07 Jul 24, 2023
735a8bc
Revert "removed package.json file"
goverdhan07 Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions __tests__/diff-snapshot.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,22 @@ describe('diff-snapshot', () => {
expect(diffResult).toHaveProperty('diffOutputPath', path.join(mockSnapshotsDir, '__diff_output__', `${mockSnapshotIdentifier}-diff.png`));
});

describe('diffImageToSnapshot', () => {
it('should fail if snapshot already exists', () => {
const { diffImageToSnapshot } = setupTest({ snapshotExists: true });
const options = {
receivedImageBuffer: mockFailImageBuffer,
snapshotIdentifier: mockSnapshotIdentifier,
snapshotsDir: mockSnapshotsDir,
updateSnapshot: false,
};

expect(() => {
diffImageToSnapshot(options);
}).toThrow();
});
});

it('should throw an error if an unknown threshold type is supplied', () => {
const diffImageToSnapshot = setupTest({ snapshotExists: true });

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions src/diff-snapshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,8 @@ const alignImagesToSameSize = (firstImage, secondImage) => {

const isFailure = ({ pass, updateSnapshot }) => !pass && !updateSnapshot;

const shouldUpdate = ({ pass, updateSnapshot, updatePassedSnapshot }) => (
(!pass && updateSnapshot) || (pass && updatePassedSnapshot)
);
const shouldUpdate = ({ pass, updateSnapshot, updatePassedSnapshot }) =>
Comment thread
goverdhan07 marked this conversation as resolved.
updateSnapshot && (!pass || (pass && updatePassedSnapshot));

const shouldFail = ({
totalPixels,
Expand Down
⚡