Merged
Conversation
6 tasks
This commit removes the default features of the `log` and `url` dependencies, which reduces the dependency count from 37 to 34. Signed-off-by: John Nunley <dev@notgull.net>
Contributor
Author
|
Oh, looks like the |
Contributor
Author
|
Actually wait, enabling the |
Contributor
Author
|
Wait, this is a bug in Still, probably a good idea to not pull in default dependencies. |
Owner
|
Thanks @notgull for your first contribution. Reducing dependencies footprint sounds good to me. The macos build failure seems to be unrelated to this PR, and the tests pass on a different macos VM I have for testing, so I'll merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the default features of the
logandurldependencies, which reduces the dependency count from 37 to 34.