Skip to content

add android support#19

Merged
amodm merged 1 commit intoamodm:masterfrom
yazgoo:master
Apr 2, 2020
Merged

add android support#19
amodm merged 1 commit intoamodm:masterfrom
yazgoo:master

Conversation

@yazgoo
Copy link
Copy Markdown
Contributor

@yazgoo yazgoo commented Jan 6, 2020

No description provided.

@amodm
Copy link
Copy Markdown
Owner

amodm commented Jan 6, 2020

Thanks for the contribution, @yazgoo. Can you put up a way to test this as well?

@yazgoo
Copy link
Copy Markdown
Contributor Author

yazgoo commented Jan 6, 2020

Thanks for the contribution, @yazgoo. Can you put up a way to test this as well?

What do you mean ? You'd like me to add a unit test specifically for android ?

@amodm
Copy link
Copy Markdown
Owner

amodm commented Jan 7, 2020

If you can, yes. https://docs.travis-ci.com/user/languages/android/

Alternatively, put up a piece of simple android code which uses this library and I'll include it in the tests.

@yazgoo
Copy link
Copy Markdown
Contributor Author

yazgoo commented Jan 8, 2020

FYI I did not create an android app per se, I'm only compiling/running my rust app in termux ( see yazgoo/youtube-subscriptions@542a87e#diff-80398c5faae3c069e4e6aa2ed11b28c0R24 )

@amodm
Copy link
Copy Markdown
Owner

amodm commented Jan 8, 2020

Ok. The reason I was asking was to quickly run that against a variety of android distribs to validate if it succeeds. I don't know enough to check if am start works across all android distributions or not. Would you be able to comment on it? Or is it better to follow something along the lines of this thread

@amodm amodm merged commit 75fad4d into amodm:master Apr 2, 2020
@amodm
Copy link
Copy Markdown
Owner

amodm commented Apr 2, 2020

Thx for your contribution

@repi repi mentioned this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants