Skip to content

Featuer/add support for wasm#26

Merged
amodm merged 3 commits intoamodm:masterfrom
hosseind2:feature/add-support-for-wasm
Jul 2, 2020
Merged

Featuer/add support for wasm#26
amodm merged 3 commits intoamodm:masterfrom
hosseind2:feature/add-support-for-wasm

Conversation

@hosseind2
Copy link
Copy Markdown

No description provided.

@hosseind2 hosseind2 changed the title featuer/add support for wasm Featuer/add support for wasm Jun 25, 2020
@amodm
Copy link
Copy Markdown
Owner

amodm commented Jun 25, 2020

@hosseind2 thanks for your first contribution here! Have you tested this with the wasm being invoked inside a browser? If yes, can you share the steps to reproduce?

@hosseind2
Copy link
Copy Markdown
Author

@hosseind2 thanks for your first contribution here! Have you tested this with the wasm being invoked inside a browser? If yes, can you share the steps to reproduce?

welcome
actually not yet, last night I wanted to use my forked version instead of main package, but there was some errors that the path is not correct
I will try this again as soon as possible and will tell you the result

@hosseind2
Copy link
Copy Markdown
Author

I tested it in browser and with new approach works correctly

Comment thread Cargo.toml Outdated
edition = "2018"


[dependencies.web-sys]
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this dependency conditional on wasm32

@hosseind2
Copy link
Copy Markdown
Author

@amodm fixed

@amodm
Copy link
Copy Markdown
Owner

amodm commented Jul 2, 2020

Lovely. Thanks. The build still fails, but I need to fix it. FYI, this will take some time to show up in the release, because I first need to fix a bunch of things on my CI.

@amodm amodm merged commit 91add0e into amodm:master Jul 2, 2020
@hosseind2
Copy link
Copy Markdown
Author

Lovely. Thanks. The build still fails, but I need to fix it. FYI, this will take some time to show up in the release, because I first need to fix a bunch of things on my CI.

ok thank you so much

@amodm
Copy link
Copy Markdown
Owner

amodm commented Jul 19, 2020

@hosseind2 this is out as 0.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants