Conversation
amodm
left a comment
There was a problem hiding this comment.
Given the test failures, I think it's best to move BrowserOptions to a non-consuming builder pattern. This way devs can selectively override the specific options they want to override
e.g. instead of saying BrowserOptions { ... }, it should be something like BrowserOptions::new().with_target_hint("_self"). If you're unsure about it, allow me to make changes to this PR so that I can get the tests to pass.
|
I changed it to the non consuming builder pattern & fixed the rustdoc. Feel free to make edits if necessary |
|
Thanks for your first contribution here @Azorlogh. This will go out in the next release (ETA 2-3 days), after I've had a chance to see if anything else needs to be included in the release. Will tag you when the release is done. |
|
Awesome, thanks! |
See #44