Skip to content

Add target_hint to BrowserOptions#45

Merged
amodm merged 3 commits intoamodm:masterfrom
Azorlogh:master
Apr 22, 2022
Merged

Add target_hint to BrowserOptions#45
amodm merged 3 commits intoamodm:masterfrom
Azorlogh:master

Conversation

@Azorlogh
Copy link
Copy Markdown
Contributor

See #44

Copy link
Copy Markdown
Owner

@amodm amodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the test failures, I think it's best to move BrowserOptions to a non-consuming builder pattern. This way devs can selectively override the specific options they want to override

e.g. instead of saying BrowserOptions { ... }, it should be something like BrowserOptions::new().with_target_hint("_self"). If you're unsure about it, allow me to make changes to this PR so that I can get the tests to pass.

Comment thread src/lib.rs Outdated
@Azorlogh
Copy link
Copy Markdown
Contributor Author

I changed it to the non consuming builder pattern & fixed the rustdoc. Feel free to make edits if necessary

@amodm amodm merged commit 0b750c2 into amodm:master Apr 22, 2022
@amodm
Copy link
Copy Markdown
Owner

amodm commented Apr 22, 2022

Thanks for your first contribution here @Azorlogh. This will go out in the next release (ETA 2-3 days), after I've had a chance to see if anything else needs to be included in the release. Will tag you when the release is done.

@amodm
Copy link
Copy Markdown
Owner

amodm commented Apr 24, 2022

@Azorlogh this is now released as v0.7.0

@Azorlogh
Copy link
Copy Markdown
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants