ios: Check we're on the main thread before opening URL#98
Closed
madsmtm wants to merge 2 commits intoamodm:mainfrom
Closed
ios: Check we're on the main thread before opening URL#98madsmtm wants to merge 2 commits intoamodm:mainfrom
madsmtm wants to merge 2 commits intoamodm:mainfrom
Conversation
`-[UIApplication openURL:options:completionHandler:]` is not safe to use from a thread that is not the main thread, since `UIApplication` is marked as `NS_SWIFT_UI_ACTOR` in the header, and the method is not marked with `NS_SWIFT_NONISOLATED` (unlike e.g. `canOpenURL:`).
Owner
|
Using #95 over this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[UIApplication openURL:options:completionHandler:]is not safe to use from a thread that is not the main thread, sinceUIApplicationis marked asNS_SWIFT_UI_ACTORin the header, and the method is not marked withNS_SWIFT_NONISOLATED(unlike e.g.canOpenURL:, which is also explicitly documented to be usable from off the main thread).See also discussion in #95, this check is present in
objc2-ui-kit.Builds upon #97 to avoid a merge conflict.